Use Sylius v1.1.0-RC #253
Merged
Use Sylius v1.1.0-RC #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
reviewed
Feb 7, 2018
composer.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "require": { | |||
| "php": "^7.1", | |||
|
|
|||
| "sylius/sylius": "^1.0", | |||
| "sylius/sylius": "^1.1", | |||
There was a problem hiding this comment.
Is there any reason to restrict version below 1.1?
Zales0123
force-pushed
the
use-stable-sylius
branch
from
4816943 to
30859b1
Compare
lchrusciel
approved these changes
Feb 7, 2018
|
Thanks Mateusz Zalewski! 🐋 |
|
Mateusz Zalewski is great, although we could run tests for both Sylius 1.0 and 1.1 (same as we do with Symfony in Sylius). |
|
That's true Kamil Kokot! It should be definitely done for this repository. Nice suggestion! |
|
All right, I've implemented it in #254. Mateusz Zalewski and Łukasz Chruściel, you might want to check that out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.