Replaced asserts with type hints #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
approved these changes
Aug 31, 2018
lchrusciel
reviewed
Aug 31, 2018
| @@ -27,13 +28,13 @@ public function it_throws_an_exception_if_order_token_is_not_a_string() | |||
| { | |||
| $this->beConstructedWith(new \stdClass(), 'COUPON_CODE'); | |||
|
|
|||
| $this->shouldThrow(\InvalidArgumentException::class)->duringInstantiation(); | |||
| $this->shouldThrow(TypeError::class)->duringInstantiation(); | |||
There was a problem hiding this comment.
But I would even think about removal of these tests right now. Strict types and scalar typehints should do the trick :)
lchrusciel
approved these changes
Aug 31, 2018
|
Thanks @mamazu! 🐋 I hope you don't mind, that I have fixed the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of the #238