Random minor fixes #306
Merged
Random minor fixes #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
force-pushed
the
minor-fixes
branch
2 times, most recently
from
f9c8d42
to
8204df6
Compare
pamil
reviewed
Sep 3, 2018
composer.json
Outdated
| "autoload-dev": { | ||
| "psr-4": { | ||
| "Tests\\Sylius\\ShopApiPlugin\\": "tests/" | ||
| }, | ||
| "classmap": ["tests/Application/app/AppKernel.php"] | ||
| }, | ||
| "config": { | ||
| "bin-dir": "bin" |
There was a problem hiding this comment.
Actually, I'd be a little against this change, Symfony 4 default structure keeps vendor binaries in vendor/bin/ directory and it's worth to stick to one convention.
lchrusciel
force-pushed
the
minor-fixes
branch
2 times, most recently
from
8ac35b6
to
0193906
Compare
lchrusciel
force-pushed
the
minor-fixes
branch
from
0193906
to
a0d689d
Compare
Zales0123
approved these changes
Sep 10, 2018
|
Nice clean-up Łukasz! 🗑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.