Adding validation to the AddProductReview endpoint
#388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason why this fails is because the master also fails. Probably the dependencies have changes the way taxons are handled. We might want to consider running the unit tests every day to track those changes. Or what do you think @lchrusciel? |
|
This is the same reason as in #385, there must have been some changes in Symfony or in serializer :/ I don't know, to be honest, how to fix it, although I've spent some time debugging it cc @pamil @lchrusciel 🚁 |
lchrusciel
reviewed
Feb 8, 2019
|
Fixed |
lchrusciel
approved these changes
Feb 12, 2019
lchrusciel
approved these changes
Feb 13, 2019
|
Thank you, @mamazu! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sylius product reviews have to have a rating between 0 and 5. Anything else is out of range. I added validation. This should also close #160.