Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to grammar #9352

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Minor fixes to grammar #9352

merged 1 commit into from
Jul 16, 2018

Conversation

gregsomers
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
License MIT

Just some minor grammar fixes I noticed while reading the docs.

I had some trouble grasping the meaning of the second sentence ("Some of them can use default factory .."), please let me know if i've accidentally changing the meaning of it.

@gregsomers gregsomers requested a review from CoderMaggie as a code owner April 19, 2018 01:24
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Apr 19, 2018
Copy link
Member

@CoderMaggie CoderMaggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gregsomers for this PR :), although we should have it opened against the 1.0 branch instead of master. Could you please rebase it?

@CoderMaggie CoderMaggie changed the base branch from master to 1.0 May 10, 2018 06:47
@pamil pamil changed the base branch from 1.0 to 1.1 July 4, 2018 17:32
@pamil pamil merged commit 328feb9 into Sylius:1.1 Jul 16, 2018
@pamil
Copy link
Contributor

pamil commented Jul 16, 2018

Thank you, Greg! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants