Upgrade to Sylius 1.3 & 1.4 and add support for PHP 7.3 #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
force-pushed
the
sylius-1.3-upgrade
branch
from
97fbdd6
to
e85a347
Compare
pamil
force-pushed
the
sylius-1.3-upgrade
branch
from
e85a347
to
f1d793c
Compare
pamil
approved these changes
Feb 7, 2019
pamil
changed the title
bartoszpietrzak1994
approved these changes
Feb 8, 2019
lchrusciel
approved these changes
Feb 8, 2019
|
Thanks, Mateusz! 🥇 |
|
And Bartosz and Kamil! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #372
Some tests were failing due to a bug in Sylius with browsing products in taxon (it was already fixed, so I suppose my overridden repository would not be necessary very soon). I've fixed almost all tests, but there are still some issues in which products don't have all their taxons listed in a response :/ If anybody has any idea what can cause these problems, I would be happy to fix it 😄 🐎