Cart summary now only works for orders in state cart #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lchrusciel The repository now uses the query builder which can not be tested but I think that getting a cart from the order repository should be inside the Sylius Core. What do you think? |
GSadee
reviewed
May 2, 2019
GSadee
reviewed
May 6, 2019
lchrusciel
approved these changes
May 7, 2019
lchrusciel
approved these changes
May 8, 2019
|
but we need to fix tests firsts |
|
I will pick it up tomorrow |
lchrusciel
force-pushed
the
cart_repository
branch
from
cc8d716 to
5436558
Compare
GSadee
approved these changes
May 10, 2019
lchrusciel
force-pushed
the
cart_repository
branch
from
5436558 to
96a2381
Compare
lchrusciel
force-pushed
the
cart_repository
branch
from
96a2381 to
0e445e4
Compare
|
Thanks, @mamazu! 🎉 |
|
Yeah, that was an obvious fix. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignoreCloses cartSummarize allows access to all orders #438