Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding company and phoneNumber to checkout/address #442

Merged
merged 2 commits into from
May 7, 2019
Merged

adding company and phoneNumber to checkout/address #442

merged 2 commits into from
May 7, 2019

Conversation

hashnz
Copy link
Contributor

@hashnz hashnz commented May 2, 2019

No description provided.

@hashnz hashnz requested a review from a team as a code owner May 2, 2019 21:17
@hashnz hashnz mentioned this pull request May 2, 2019
Closed
@mamazu
Copy link
Member

mamazu commented May 3, 2019

Are those options now required or are they optional?

@hashnz
Copy link
Contributor Author

hashnz commented May 5, 2019

@mamazu they should be optional, there's a test here that doesn't pass them in

ShopApiPlugin/tests/Controller/Checkout/CheckoutSummarizeApiTest.php

Line 112 in 762ecd7

public function it_shows_an_order_with_chosen_shipment(): void

@dlobato
Copy link
Contributor

dlobato commented May 6, 2019

new fields are not reflected on swagger definition

@hashnz
Copy link
Contributor Author

hashnz commented May 6, 2019

@dlobato thanks, I've added those

@mamazu mamazu merged commit c056ccb into Sylius:master May 7, 2019
@mamazu
Copy link
Member

mamazu commented May 7, 2019

Thanks, Matt! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@mamazu mamazu mamazu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hashnz @mamazu @dlobato @lchrusciel