Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to License file #70

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix path to License file #70

merged 2 commits into from
Oct 21, 2024

Conversation

cezarpopa
Copy link
Contributor

Hi,

I hope all is well. I noticed that the license file path was incorrect, so I corrected the path to the LICENSE file in the README.md to ensure it links properly.

Thanks,
Cezar

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Just a little question about the unrelated change

README.md Outdated
@@ -14,7 +14,7 @@ Read the documentation at: https://symfony.com/bundles/TailwindBundle/current/in

Is this package useful? We're *thrilled* 😍!

A lot of time & effort from the Symfonycasts team & the Symfony community
A lot of time and effort from the Symfonycasts team & the Symfony community
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any strong reason for changing & -> and here? I mean, & is the correct shortened version of and anyway, moreover later on this line we still have &. Any comments on this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, my bad. That shouldn't have been there.

I will remove that in a bit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted. Thank you!

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you for this fix!

@bocharsky-bw bocharsky-bw merged commit 17b636f into SymfonyCasts:main Oct 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants