minor: fix failing windows tests #76
Merged
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
fix/windows-exe
branch
from
0a59f0b
to
d31e217
Compare
kbond
force-pushed
the
fix/windows-exe
branch
from
d31e217
to
4a9ce84
Compare
bocharsky-bw
approved these changes
Nov 6, 2024
|
It did feel a bit like we were testing Process. |
MolloKhan
reviewed
Nov 7, 2024
|
|
||
| $this->assertSame( | ||
| \sprintf($expectedTemplate, $binaryDownloadDir.'/fake-version/'.TailwindBinary::getBinaryName()), | ||
| (new Process([$binaryFile, '-i', 'fake.css'], __DIR__))->getCommandLine(), |
There was a problem hiding this comment.
A comment here describing why you're asserting the command line in that way would be handy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an upstream change in
symfony/process, windows executables are no longer wrapped in double quotes.