APP-3274 - Update React imports to use standard style. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lint is failing @sasha-symphony |
| @@ -47,7 +47,7 @@ describe('Key Utils', () => { | |||
| it(`should handle ${test.key} shift=${test.shiftKey} on cell`, () => { | |||
| const event = createEvent({ key: test.key, shiftKey: test.shiftKey }); | |||
| const wrapper = shallow( | |||
| <div onKeyDown={(e) => handleKeyDownCell(new Date(), e, setMethod, setMethod2, {})} /> | |||
| <div onKeyDown={(e) => handleKeyDownCell(new Date(), e, setMethod, setMethod2, ()=>{}, {})} /> | |||
There was a problem hiding this comment.
is this a mistake? :D
There was a problem hiding this comment.
No. handleKeyDownCell takes 6 params, but this test was only supplying 5, and the 5th one was wrong. I simply added an empty function for focusDiv. Perhaps some of the types are supposed to be optional. The locale isn't typed at all.
export function handleKeyDownCell(
date: Date,
e: React.KeyboardEvent,
setNavigationDate: (date) => any,
setDivToFocus: (date) => any,
focusDiv: (date) => any,
locale
)
There was a problem hiding this comment.
I reverted this change, as it isn't technically within the scope of this PR, but it should be fixed.
The error I was attempting to fix was a missing parameter. If any of the parameters are optional, they should be labelled as such, and the locale param should have a type. @AliciaSymphony
symphony-adnane
approved these changes
Nov 12, 2020
sasha-symphony
requested review from
AliciaSymphony,
swasunb and
axeleriksson147
and removed request for
symphony-adnane
swasunb
approved these changes
Nov 13, 2020
symphony-adnane
approved these changes
Nov 13, 2020
ghost
unassigned
symphony-jean-michael
referenced
this pull request
in symphony-jean-michael/symphony-bdk-ui-toolkit-components
Nov 4, 2021
APP-3785 Difference option and tk-option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding uitoolkit-components as a dependency to SFE-Lite, typescript complains about the use of
This PR updates all components to use the preferred
Links
PR in react repo establishing this as standard.
JIRA-ticket