Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix STIR HDF5 #1230

Closed
wants to merge 1 commit into from
Closed

fix STIR HDF5 #1230

wants to merge 1 commit into from

Conversation

KrisThielemans
Copy link
Member

We're using #ifdef HAVE_HDF5 but it should be STIR_built_with_HDF5. On my local machine, HAVE_HDF5 is defined, although I cannot find where, so it was enabled, but on GHA it probably isn't.

I'll test that first. Then replace.

@KrisThielemans
Copy link
Member Author

HAVE_HDF5 is set in STIR/config.h. STIR_built_with_HDF5 is a CMake variable.

So this was all ok. Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KrisThielemans