Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Moving SyneRBI-Challenge nema-data utilities to SIRF (#1241)" #1263

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

KrisThielemans
Copy link
Member

This reverts commit b90383e.

Copy link
Contributor

@evgueni-ovtchinnikov evgueni-ovtchinnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not mind reverting if what I have done is not good enough, but I am afraid I am completely lost now. If randoms cannot be computed for SPECT data, we need a method that computes prompts only, do we not? BTW is there a way to find out whether one has PET or SPECT data?

@KrisThielemans
Copy link
Member Author

If randoms cannot be computed for SPECT data, we need a method that computes prompts only, do we not?

sure, but we have one already, i.e. the set_input, process(), get_output().

BTW is there a way to find out whether one has PET or SPECT data?

You have to get into stir::ExamInfo::imaging_modality. We don't expose any of that to SIRF, and will have to.

@KrisThielemans KrisThielemans merged commit 7e81f31 into SyneRBI:master Jun 6, 2024
6 checks passed
@KrisThielemans KrisThielemans deleted the revert_1241 branch June 6, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants