Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue working on moving Challenge data preparation utilities to SIRF. #1266

Merged
merged 30 commits into from
Jun 11, 2024

Conversation

evgueni-ovtchinnikov
Copy link
Contributor

Changes in this pull request

Testing performed

Related issues

PR #1241

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

@KrisThielemans
Copy link
Member

I won't have time to review this today, but I think you've addressed my main concerns, so go ahead when you're ready.

Given the tortuous history here, I suggest a squash-merge, but please edit the commit message such that it not just a list of all the attempts, but an overall conclusion. (Note that I see you're adding modality, which is great, so add that to the CHANGES.md).

thanks!

@KrisThielemans
Copy link
Member

looks like you still need to remove examples/Python/PET/test_data_preparation.py

@evgueni-ovtchinnikov evgueni-ovtchinnikov merged commit 8169df2 into master Jun 11, 2024
1 check passed
@evgueni-ovtchinnikov evgueni-ovtchinnikov deleted the ch2sirf branch June 11, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants