Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local.mk: add option to disable github api call for maintainer #6312

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Nov 9, 2024

Description

  • spksrc.spk.mk uses the github api to get the realname and the url of the package maintainer
  • if you build packages too often (e.g. small diyspk packages) you can reach the api rate limit and the build fails
  • for this case you can define DISABLE_GITHUB_MAINTAINER with any non empty value (1, true, ...) to avoid the api call
  • if DISABLE_GITHUB_MAINTAINER is defined the MAINTAINER is used as defined and the MAINTERNER_URL is set to "https://github.com/SynoCommunity" if not defined in the package

Type of change

  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

- spksrc.spk.mk uses the github api to get the realname and the url of the package maintainer
- if you build packages too often (e.g. small diyspk packages) you can reach the api rate limit and the build fails
- for this case you can define DISABLE_GITHUB_MAINTAINER with any non empty value (1, true, ...) to avoid the api call
- if DISABLE_GITHUB_MAINTAINER is defined the MAINTAINER is used as defined and the MAINTERNER_URL is set to "https://github.com/SynoCommunity" if not defined in the package
@hgy59 hgy59 added the framework label Nov 9, 2024
@hgy59
Copy link
Contributor Author

hgy59 commented Nov 9, 2024

@th0ma7 I faced this issue when updating a lot of tools of synocli-file in #6288.

see github: Rate limits for the REST API

EDIT:
AFAICS the rate limit is 60 api calls / hour for unauthenticated users.

Copy link
Contributor

@th0ma7 th0ma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hgy59 hgy59 merged commit 08133d2 into SynoCommunity:master Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants