Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sip-2036.md #1721

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Update sip-2036.md #1721

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bccb9a7
Update sip-2036.md
kaleb-keny Oct 15, 2023
e2cc4fc
Update sip-2036.md
kaleb-keny Oct 15, 2023
626f929
Update sip-2036.md
kaleb-keny Oct 15, 2023
b63c86f
Update sip-2036.md
kaleb-keny Oct 15, 2023
a86fc1e
Update sip-2036.md
kaleb-keny Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions content/sips/sip-2036.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,17 @@ This SIP proposes to incorporate a revert, that throws the entire minting transa
5. Configurable Values
-->

Pending
The fix entails reverting the inflation mint transaction, if a programmed distribution fails to sucessfully execute, in the [`RewardsDistribution.sol`](https://github.com/Synthetixio/synthetix/pull/2160/files#diff-31f3ee2aa3dfdba395e7dfb288545f20085d1e41053e64a009981a5edab44256R175) contract.

It is worth mentioning as a consequence of this fix, all future contracts that would receive snx distributions, will need to implement a `notifyReward` in the receiving contract, otherwise the distribution and weekly inflation print will fail. Currently, as per the state of the v2X contracts, at the time of writing this sip, no contracts are configured to receive snx inflation on a weekly basis, aside from [`SynthetixBridgeToOptimism.sol`](https://etherscan.io/address/0x39Ea01a0298C315d149a490E34B59Dbf2EC7e48F).

### Technical Specification

<!--The technical specification should outline the public API of the changes proposed. That is, changes to any of the interfaces Synthetix currently exposes or the creations of new ones.-->

Pending

### Test Cases

<!--Test cases for an implementation are mandatory for SIPs but can be included with the implementation..-->

In case the distribution of rewards to L2 stakers fails, the entire `Synthetix.mint()` should revert.


### Configurable Values (Via SCCP)

<!--Please list all values configurable via SCCP under this implementation.-->
Expand Down
Loading