Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIP-182 Wrapper Factory #1489

Merged
merged 47 commits into from
Oct 26, 2021
Merged

SIP-182 Wrapper Factory #1489

merged 47 commits into from
Oct 26, 2021

Commits on Aug 31, 2021

  1. theoretical contract changes 

    stubbed currently:
* totalIssuedSynths calculation
* distributeFees

tests to come
    @dbeal-eth
    dbeal-eth committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    6059132 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. add tests for wrapper, and stub for wrapperfactory

    @dbeal-eth
    dbeal-eth committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    c7f9a84 View commit details
    Browse the repository at this point in the history

  2. fix tests 

    only tests remaining now are related to:
* totalIssuedSynths (DebtCache)
* distributeFees
* WrapperFactory general
    @dbeal-eth
    dbeal-eth committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    4fc47ec View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. add comment

    @dbeal-eth
    dbeal-eth committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    64dc546 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. fix tests for WrapperFactory 

    pretty much the only remaining thing now is DebtCache related
    @dbeal-eth
    dbeal-eth committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    b2c5571 View commit details
    Browse the repository at this point in the history

  2. more test fixes

    @dbeal-eth
    dbeal-eth committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    55fc210 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2021

  1. implement excludedDebt in DebtCache, fixed associated tests 

    After discussion it has been decided that the best way to manage debt exclusions for
Wrappers is to report them directly to the debtcache, and then the debtcache can calculate
the actual excluded debt values and produce result.

there is currently one failing test that I don't think I touched (and if I did its a really wierd error)
    @dbeal-eth
    dbeal-eth committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    5369678 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. re-add old ether wrapper in case we need

    @dbeal-eth
    dbeal-eth committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    56a9c72 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. add missing mock file

    @dbeal-eth
    dbeal-eth committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    fc5e171 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Merge branch 'abstract-wrapper-with-old-ether' into abstract-eth-wrapper

    @dbeal-eth
    dbeal-eth committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    7460d21 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into abstract-eth-wrapper

    @dbeal-eth
    dbeal-eth committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    d61d750 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. fix test failures and misses

    @dbeal-eth
    dbeal-eth committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    72c1249 View commit details
    Browse the repository at this point in the history

  2. fix accidential synths local-ovm update

    @dbeal-eth
    dbeal-eth committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    fc6167d View commit details
    Browse the repository at this point in the history

  3. add missing tests

    @dbeal-eth
    dbeal-eth committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    4d3ed73 View commit details
    Browse the repository at this point in the history

  4. fix duplicate maxTokenAmountCall

    @dbeal-eth
    dbeal-eth committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    1e7c4b2 View commit details
    Browse the repository at this point in the history

  5. better naming pattern

    @dbeal-eth
    dbeal-eth committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    586818d View commit details
    Browse the repository at this point in the history

  6. replace with safemath

    @dbeal-eth
    dbeal-eth committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    db11994 View commit details
    Browse the repository at this point in the history

  7. try fix test failures

    @dbeal-eth
    dbeal-eth committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    3fe239e View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. fix math error

    @dbeal-eth
    dbeal-eth committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    5a23fc2 View commit details
    Browse the repository at this point in the history

  2. fix local-ovm deployment oops

    @dbeal-eth
    dbeal-eth committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    8aa3ff9 View commit details
    Browse the repository at this point in the history

  3. remove unused totalIssuedSynths

    @dbeal-eth
    dbeal-eth committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9d1a5e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. update to allow for negative fees

    @dbeal-eth
    dbeal-eth committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    0d70923 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. fix comment

    @dbeal-eth
    dbeal-eth committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    34c2b7b View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2021

  1. fix(test): extract correct address from event

    @leckylao
    leckylao committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    19c8bc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Try to fix CI by loading the contract with ethers 

    - removed duplicate import
    @leckylao
    leckylao committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    d8e71b8 View commit details
    Browse the repository at this point in the history

  2. using ethers from hardhat

    @leckylao
    leckylao committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    68fd43e View commit details
    Browse the repository at this point in the history

  3. Try to fix integration test 

    - revert to use getContractFactory
    @leckylao
    leckylao committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    89389aa View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. deploying WETH for OVM integration test

    @leckylao
    leckylao committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    3057c1a View commit details
    Browse the repository at this point in the history

  2. perf(test): fix WrapperFactory integration test: 

    - adding compiled to load Wrapper abi
- adding "-d" for Ops start
    @leckylao
    leckylao committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    4d04cd4 View commit details
    Browse the repository at this point in the history

  3. revert "-d" option on Ops start

    @leckylao
    leckylao committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    fac5931 View commit details
    Browse the repository at this point in the history

  4. Add fallback coverage

    @barrasso
    barrasso committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    d65f99b View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Merge develop into abstract-eth-wrapper

    @barrasso
    barrasso committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    f2fbc13 View commit details
    Browse the repository at this point in the history

  2. Fix merge conflict

    @barrasso
    barrasso committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    e160741 View commit details
    Browse the repository at this point in the history

  3. fix slither security alerts

    @barrasso
    barrasso committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    d147d8a View commit details
    Browse the repository at this point in the history

  4. remove unused code

    @barrasso
    barrasso committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    7017dd0 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Merge branch 'develop' into abstract-eth-wrapper

    @barrasso
    barrasso authored Oct 15, 2021
    Configuration menu
    Copy the full SHA
    9192ea5 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Merge branch develop into abstract-eth-wrapper and fix conflicts

    @barrasso
    barrasso committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    4f6e1b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. changes requested by isiro 

    * use safeTransferFrom
* use `issuanceActive` modifier when issuing with `mint` or `burn`
* fix potential case of burning more than expected synth
* check that fees actually exist before sending fees to WrapperFactory
* require that only one of `wrapperMintFeeRate` or `wrapperBurnFeeRate` can be negative at a time
    @dbeal-eth
    dbeal-eth committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    2b76dca View commit details
    Browse the repository at this point in the history

  2. fix lint test

    @barrasso
    barrasso committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    1f2847e View commit details
    Browse the repository at this point in the history

  3. update _totalNonSnxBackedDebt to better handle excluded debt 

    also fix releases file with Synths.*
    @dbeal-eth
    dbeal-eth committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    d41faf2 View commit details
    Browse the repository at this point in the history

  4. checkout to dev branch updateCachedSynthDebtsWithRates

    @dbeal-eth
    dbeal-eth committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    077b0e8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'abstract-eth-wrapper' of https://github.com/Synthetixio… 

    …/synthetix into abstract-eth-wrapper
    @dbeal-eth
    dbeal-eth committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    61a0fad View commit details
    Browse the repository at this point in the history

  6. re-add debt-cache comment

    @dbeal-eth
    dbeal-eth committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    447401c View commit details
    Browse the repository at this point in the history

  7. fix isInvalid

    @dbeal-eth
    dbeal-eth committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    1fc0b87 View commit details
    Browse the repository at this point in the history

  8. fix unneeded constants

    @dbeal-eth
    dbeal-eth committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    66e944e View commit details
    Browse the repository at this point in the history

  9. remove convenience function and accompanying modifier

    @dbeal-eth
    dbeal-eth committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    f52432a View commit details
    Browse the repository at this point in the history

  10. fix minor things

    @dbeal-eth
    dbeal-eth committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    5ddb558 View commit details
    Browse the repository at this point in the history