-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improvements and maintenance #1510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
This reverts commit 416f0d0.
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
This reverts commit 8212faa.
This reverts commit 5100bb9.
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
jjgonecrypto
approved these changes
Sep 17, 2021
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com> # Conflicts: # package-lock.json
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Codecov Report
@@ Coverage Diff @@
## develop #1510 +/- ##
========================================
Coverage 95.21% 95.21%
========================================
Files 76 76
Lines 1733 1733
Branches 557 557
========================================
Hits 1650 1650
Misses 83 83 Continue to review full report at Codecov.
|
dbeal-eth
approved these changes
Sep 20, 2021
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
This reverts commit 0b6e35a.
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
job-audit
beforejob-prepare
with two additional steps:npm audit
which will fail the whole workflow only if there is critical vulnerability detected in dependencies (npm install
will never be triggered in this case increasing security)lockfile-lint
which makes sure that lockfile is up to date and has no malicious stuff insideNew workflow:
side note:
job-fork-tests
is also failing ondevelop
branch, so it's not related to my changes.