Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improvements and maintenance #1510

Merged
merged 43 commits into from
Sep 21, 2021
Merged

ci: improvements and maintenance #1510

merged 43 commits into from
Sep 21, 2021

Conversation

drptbl
Copy link
Contributor

@drptbl drptbl commented Sep 16, 2021

Changes:

  • updated docker containers to use latest node version (14.17.6) and npm (7.23.0)
  • use codecov uploader instead of bash script which is deprecated
  • added job-audit before job-prepare with two additional steps:
    • npm audit which will fail the whole workflow only if there is critical vulnerability detected in dependencies (npm install will never be triggered in this case increasing security)
    • lockfile-lint which makes sure that lockfile is up to date and has no malicious stuff inside
  • updated base runner ubuntu image to use the latest
  • improved caching of node dependencies
  • updated codechecks dependency
  • increased timeout for integration tests
  • fixed codecov github checks which were missing in PRs

New workflow:
Screenshot 2021-09-16 at 17 19 00

side note:
job-fork-tests is also failing on develop branch, so it's not related to my changes.

Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
This reverts commit 5100bb9.
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
@drptbl drptbl marked this pull request as draft September 16, 2021 20:24
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
@jjgonecrypto jjgonecrypto marked this pull request as ready for review September 17, 2021 16:22
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>

# Conflicts:
#	package-lock.json
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #1510 (b88518d) into develop (105a4b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1510   +/-   ##
========================================
  Coverage    95.21%   95.21%           
========================================
  Files           76       76           
  Lines         1733     1733           
  Branches       557      557           
========================================
  Hits          1650     1650           
  Misses          83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105a4b5...b88518d. Read the comment docs.

Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
Signed-off-by: Jakub Mucha <jakub.mucha@icloud.com>
@jjgonecrypto jjgonecrypto merged commit bd54f4e into develop Sep 21, 2021
@jjgonecrypto jjgonecrypto deleted the ci-improvements branch September 21, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants