-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sip 185 debt shares #1601
Merged
Merged
Sip 185 debt shares #1601
Changes from 9 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
6522f12
add synthetixdebtshare
dbeal-eth 510823f
lots of implementation
dbeal-eth 8ed2fff
tests work
dbeal-eth 834ec9d
add synthetix debt share tests
dbeal-eth bff2fb6
fix unit test failures
dbeal-eth 9043de1
remove comments and np
dbeal-eth ae5c111
fix lints
dbeal-eth d532380
initial period is now 1
dbeal-eth 3b53405
add a few tests for coverage
dbeal-eth 5076ab1
use `hardhat-interact` instead of builtin
dbeal-eth e351a65
fix module resolution
dbeal-eth f1280ab
fix package lock again
dbeal-eth fea5c91
fix provider url issues and network id for kvoan
dbeal-eth 10ea7bd
add synthetixdebtshare
dbeal-eth 7cf745b
lots of implementation
dbeal-eth 113ada3
tests work
dbeal-eth f267e6e
add synthetix debt share tests
dbeal-eth 667fcc8
fix unit test failures
dbeal-eth 2265bf6
remove comments and np
dbeal-eth fb1530a
fix lints
dbeal-eth bdf3e69
initial period is now 1
dbeal-eth 87cd0da
add a few tests for coverage
dbeal-eth 8171cb3
now its not necessary to work around load-contracts functionality wit…
dbeal-eth 1deac59
Merge branch 'sip-185-debt-shares' of https://github.com/Synthetixio/…
dbeal-eth e961d51
oops
dbeal-eth 09c501e
add migration script start
dbeal-eth 54bc7b2
Merge branch 'develop' into sip-185-debt-shares
barrasso 26bddc0
remove unnecessary migration contracts
barrasso 093812a
Update package-lock.json
barrasso 7b052d8
fix SynthetixDebtShare allowance tests and update interface
barrasso 074f973
fix remaining unit tests
barrasso 3c10f8d
Merge branch 'develop' into sip-185-debt-shares
barrasso f70d5e3
Merge branch 'develop' into sip-185-debt-shares
barrasso 9005af7
Merge branch 'sip-185-debt-shares' of https://github.com/Synthetixio/…
barrasso a4e67b9
final fixes
dbeal-eth 7d91e8a
Merge branch 'develop' into sip-185-debt-shares
dbeal-eth 832fe23
Merge branch 'develop' into sip-185-debt-shares
dbeal-eth 1b12e4c
add apparently missing tests for importAddresses
dbeal-eth 3783e05
fixes for reccomendations from @artdgn
dbeal-eth 6104a06
more small cleanups
dbeal-eth 1c8d00c
better balance history scanning
dbeal-eth da67a27
update docs
dbeal-eth 21e76b9
Merge branch 'develop' into sip-185-debt-shares
barrasso 63dc62b
minor formatting fix
barrasso d8aeb25
remove unneeded migration contracts
barrasso 9e35b2b
fix lint error
barrasso f3537b9
Merge branch 'develop' into sip-185-debt-shares
barrasso afdefac
Merge remote-tracking branch 'origin/develop' into sip-185-debt-shares
dbeal-eth 49d8a69
fixes for comments from audit
dbeal-eth dc3c276
add requirements for v3
dbeal-eth 804a96b
Merge remote-tracking branch 'origin/develop' into sip-185-debt-shares
dbeal-eth 19eb553
final audit notes
dbeal-eth 331cb88
Merge remote-tracking branch 'origin/develop' into sip-185-debt-shares
dbeal-eth 82c0c70
add support for complete control of altering balance during initial p…
dbeal-eth 43b6fe1
fix lint
dbeal-eth fe3e180
Merge remote-tracking branch 'origin/develop' into sip-185-debt-shares
dbeal-eth ebdb8b0
fix tests... again?
dbeal-eth 86bde07
fix scripts and stuff
dbeal-eth 1053059
remove legacy contracts
dbeal-eth d0c69d5
fix integration tests && remove unnecessarsy changes
dbeal-eth b9add27
fix integration caught bug for `importFeePeriod`
dbeal-eth 15202c1
undo accidental changes to config.json
dbeal-eth b8e0e9a
fix deploy tests
dbeal-eth dd7961b
fix task node
dbeal-eth 9b54331
remove unnecessary conditional
dbeal-eth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not check whether the account has any debt shares balance (directly from the SDS contract) and if 0, you could save more gas and skip this check for transferring ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I just wanted to reuse the
issuer
dependency. You are right, checking the debt shares contract directly would make more sense.