Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for latest version of cannon #2222

Merged
merged 2 commits into from
Mar 18, 2024
Merged

support for latest version of cannon #2222

merged 2 commits into from
Mar 18, 2024

Conversation

dbeal-eth
Copy link
Contributor

No description provided.

@dbeal-eth dbeal-eth requested a review from barrasso March 18, 2024 13:13
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (3d068fc) to head (65827c7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2222   +/-   ##
========================================
  Coverage    92.48%   92.48%           
========================================
  Files           91       91           
  Lines         2274     2274           
  Branches       672      672           
========================================
  Hits          2103     2103           
  Misses         171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barrasso barrasso merged commit a40e2c6 into develop Mar 18, 2024
20 of 23 checks passed
@barrasso barrasso deleted the cannon-211 branch March 18, 2024 15:08
@dbeal-eth
Copy link
Contributor Author

@barrasso are the CI tests supposed to succeed here? seems to be the same failures as develop.

@barrasso
Copy link
Member

barrasso commented Mar 19, 2024

@barrasso are the CI tests supposed to succeed here? seems to be the same failures as develop.

The integration job failing is expected at the moment: #2214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants