Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Rhea ids #506

Merged
merged 8 commits into from
Mar 21, 2023
Merged

feat: update Rhea ids #506

merged 8 commits into from
Mar 21, 2023

Conversation

haowang-bioinfo
Copy link
Member

Main improvements in this PR:

This PR improves reacitons.tsv annotation file by updating a total of 1301 Rhea master IDs:

  • add 1297 new IDs by mapping from KEGG ids
  • manually modify 4 IDs that wrongly associated previously

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@mihai-sysbio
Copy link
Member

Awesome! Was this done by manually uploading the list of KEGG ids?

@haowang-bioinfo
Copy link
Member Author

haowang-bioinfo commented Mar 21, 2023

yes, these ids were mapped by uploading the list of KEGG ids, some conflicting ones were manually checked

@haowang-bioinfo haowang-bioinfo marked this pull request as ready for review March 21, 2023 09:18
Copy link
Member

@mihai-sysbio mihai-sysbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@haowang-bioinfo
Copy link
Member Author

this PR is a bit overlap with #504, but should be okay to merge it and move forward

@haowang-bioinfo haowang-bioinfo merged commit edf973f into develop Mar 21, 2023
@mihai-sysbio mihai-sysbio deleted the feat/updateRheaIDs branch March 21, 2023 12:02
@haowang-bioinfo haowang-bioinfo mentioned this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants