Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrongly annotated genes for glycolysis pathway and lactate dehydrogenase #517

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

feiranl
Copy link
Collaborator

@feiranl feiranl commented Mar 29, 2023

Main improvements in this PR:

This PR removes wrongly annotated genes in glycolysis pathway #507 and remove genes for lactate dehydrogenase #516

Note: all these genes are existed as isoenzymes in GPRs, so that their removal has no much impact to the model.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far ENSG00000154305 is removed. How about ENSG00000132746, ENSG00000149925, ENSG00000166800 that were proposed in #507

@feiranl
Copy link
Collaborator Author

feiranl commented Mar 29, 2023

In that issue, I mean remove the gene from GPR in the specific rxn.

@haowang-bioinfo haowang-bioinfo merged commit 0b1bd42 into develop Mar 29, 2023
@haowang-bioinfo haowang-bioinfo deleted the refine-gly branch March 29, 2023 18:56
@haowang-bioinfo haowang-bioinfo mentioned this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants