Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new reactions annotated for genes related to Glycolysis pathway #530

Closed
wants to merge 3 commits into from

Conversation

feiranl
Copy link
Collaborator

@feiranl feiranl commented Apr 7, 2023

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@haowang-bioinfo
Copy link
Member

The Yaml validation step verifies the consistency between Yaml model file and tsv files of reactions.tsv and metabolites.tsv. The failure of this step means that tsv files should be modified to match with the model, which, as demonstrated by the Yaml conversion step, appears to be fine.

@mihai-sysbio
Copy link
Member

Looking into the logs of the validation check below, it seems many (all?) errors are caused: trailing spaces (trailing-spaces). This means that in Human-GEM.yml spaces have been added at the end of the line.

@mihai-sysbio
Copy link
Member

mihai-sysbio commented Apr 8, 2023

After correcting the trailing spaces in commit 037e7b8, the error that @haowang-bioinfo indicated previously becomes obvious in the logs as well:

  File "/__w/Human-GEM/Human-GEM/code/test/sanityCheck.py", line 53, in checkMetAnnotation
    assert metList == mets, "Metabolite annotation mismatch!"
AssertionError: Metabolite annotation mismatch!
Error: Process completed with exit code 1.

@feiranl
Copy link
Collaborator Author

feiranl commented Apr 14, 2023

@mihai-sysbio could you tell me what should I do to fix this error? I thought it was that I reused the deprecated met IDs, but I intersected the mets in metabolites.tsv and deprecatedMetabolites.tsv and found none.

@mihai-sysbio
Copy link
Member

@mihai-sysbio could you tell me what should I do to fix this error? I thought it was that I reused the deprecated met IDs, but I intersected the mets in metabolites.tsv and deprecatedMetabolites.tsv and found none.

My suspicion is that some of the new identifiers added in the YML file have not been added to the TSV. One can run the Python code locally as well (with a printout) to see the exact problem. Let me know if you can't find the root cause.

@feiranl
Copy link
Collaborator Author

feiranl commented Apr 15, 2023

Closing this PR since it was redo in #534 and #535. This error in yaml validation was caused by the inconsistent met order in model.mets and metAnnotation file.

@feiranl feiranl closed this Apr 15, 2023
@haowang-bioinfo haowang-bioinfo deleted the feat-addglynewrxn branch April 18, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants