Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gene symbols to model #549

Merged
merged 7 commits into from
May 7, 2023
Merged

Conversation

haowang-bioinfo
Copy link
Member

@haowang-bioinfo haowang-bioinfo commented May 4, 2023

Main improvements in this PR:

This PR improves usability by adding gene symbols, as discussed in #539

  • extract gene symbols from genes.tsv and embed into Human-GEM as geneShortNames field
  • enable importYaml to load model with this field

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

- extract gene symbols from genes.tsv and include to Human-GEM
@haowang-bioinfo haowang-bioinfo marked this pull request as draft May 4, 2023 08:26
@mihai-sysbio
Copy link
Member

I'm wondering if this will be in line with the cobrapy yaml, and if this format will still make it in the sbml export.

@haowang-bioinfo
Copy link
Member Author

have the same concerns that should be ensured

@haowang-bioinfo haowang-bioinfo marked this pull request as ready for review May 4, 2023 19:32
@haowang-bioinfo
Copy link
Member Author

the Yaml file with embedded gene names has been tested and now compatible with:

  • Human-GEM code set
  • Cobra Toolbox
  • RAVEN Toolbox
  • Cobrapy

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haowang-bioinfo
Copy link
Member Author

haowang-bioinfo commented May 7, 2023

to ensure new contributors added to main branch will be retained for new release when merging develop branch (that will overwritten main forcefully), those commits were cherry picked to here.

@haowang-bioinfo haowang-bioinfo merged commit 06ea460 into develop May 7, 2023
@haowang-bioinfo haowang-bioinfo deleted the feat/addGeneSymbols branch May 7, 2023 20:43
@haowang-bioinfo haowang-bioinfo mentioned this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants