Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge fix/constructEquations branch with devel #155

Merged
merged 1 commit into from
Sep 10, 2018
Merged

merge fix/constructEquations branch with devel #155

merged 1 commit into from
Sep 10, 2018

Conversation

JonathanRob
Copy link
Collaborator

Main improvements in this PR:

  • constructEquations was incorrectly retrieving metabolite compartments, but this has now been repaired.

I hereby confirm that I have:

@JonathanRob
fix: constructEquations bugfix, was assigning compartments incorrectly
e8900e8 
The original code was extracting the compartment of only the first metabolite involved in a reaction, rather than all the compartments. This has been fixed.
@BenjaSanchez BenjaSanchez self-requested a review September 7, 2018 12:01
BenjaSanchez
BenjaSanchez approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@BenjaSanchez BenjaSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely spotted! thanks

@simas232 simas232 merged commit 51d8e51 into devel Sep 10, 2018
@simas232 simas232 deleted the fix/constructEquations branch September 10, 2018 11:16
@edkerk edkerk mentioned this pull request Sep 27, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaSanchez BenjaSanchez BenjaSanchez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonathanRob @BenjaSanchez @simas232