-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove genes not found in S288C annotation #129
Comments
@BenjaSanchez |
@hongzhonglu should then be removed? We should only keep genes belonging to the strain of the model I think. |
@BenjaSanchez As we discussed in last meeting, the present yeast-GEM will be developed as pan-model of Saccharomyces cerevisiae. The strain specific model will be obtained based on yeast-GEM. In this case, it is OK to include these two genes. |
@BenjaSanchez @hongzhonglu The general |
@edkerk @BenjaSanchez Great! We are also thinking about it. So when are you free? |
During our offline discussion on Monday we decided that |
Thanks a lot, @edkerk, @BenjaSanchez and @hongzhonglu . Now, my life is easier. |
As discussed in #129, YAR069W-A and YHR214W-F are not from the s288c strain and therefore are here removed
Description of the issue:
I was contacted by @snmendoz who pointed out that 2 of the current genes in the model cannot be found in the annotation of strain S288C, according to NCBI:
YAR069W-A
andYHR214W-F
. @hongzhonglu do you see these genes in any of the newly added annotations? If so, are the annotations of those genes publicly available somewhere?I hereby confirm that I have:
master
branch of the repositoryThe text was updated successfully, but these errors were encountered: