Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/SLIME rxns #112

Merged
merged 3 commits into from
May 29, 2018
Merged

Feat/SLIME rxns #112

merged 3 commits into from
May 29, 2018

Conversation

BenjaSanchez
Copy link
Contributor

@BenjaSanchez BenjaSanchez commented May 20, 2018

Main improvements in this PR:

This PR addresses #21 with a novel way for constraining lipid metabolism (see SysBioChalmers/SLIMEr):

  • SLIME rxns replace old ISA rxns for lumping lipids.
  • There are now 3 lipid pseudoreactions: 1 constrains backbones, 1 constrains acyl chains, 1 merges both.
  • Biomass composition was rescaled to experimental data from Lahtvee et al. 2017.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

+ biomass composition adapted to data from reference conditions in study from Lahtvee et al. 2017.
@BenjaSanchez BenjaSanchez added enhancement new field/feature curation labels May 20, 2018
@BenjaSanchez BenjaSanchez self-assigned this May 20, 2018
@BenjaSanchez BenjaSanchez changed the title Feat/slim erxns Feat/SLIME rxns May 20, 2018
@edkerk
Copy link
Member

edkerk commented May 25, 2018

It's unclear to me how you defined the chemical formulae of the pseudo metabolites. Could you show for instance why triglyceride has chemical formula C3H2?

@BenjaSanchez
Copy link
Contributor Author

BenjaSanchez commented May 25, 2018

@edkerk sure! Let's take tryglyceride (16:1-16:1-16:1): The molecular formula is C51H92O6, and the corresponding SLIME rxn creates a backbone + 3 chains of palmitoleic acid C16H30O2 (note, not palmitoleate, which has one H less). Then I mass balance those formulas: C51H92O6 - 3*(C16H30O2) = C3H2, to display clearly that a SLIME rxn is indeed "splitting" the lipid. You can see the code in addSLIMErxn.m. The alternative would be to include the radicals and make the formula C3H2R3, or even C3H6R3, which looks nicer based on the known structure for triglycerides but double accounts for 3 H's (already included in the acyl chains). Also those 2 approaches are "unbalanced" in the amount of radicals... Then again SLIME rxns are already unbalanced due to the stoich coeffs so maybe this is not an issue.

image (could not find a pic for 16:1-16:1-16:1)

I would not try to balance the rxns as the stoichiometries would be long decimals, but any of the 3 aforementioned options would be fine by me, so let me know which one you think makes more sense and I can adapt the pipeline to that.

@edkerk
Copy link
Member

edkerk commented May 25, 2018

@BenjaSanchez thanks for the clear justification. I think it's important that combining the formulae of backbone + chain ideally yields the full formula (as you detailed C51H92O6 - 3*(C16H30O2) = C3H2). I would suggest two options:

  1. Use C3H2R3-type formulae for backbones. It's not completely balanced, but the names of the backbones suggest that they represent a complete lipid species, and this could be captured by including R.
  2. Specify in the metabolite names of backbones that they only represent... backbones. So keep using the C3H2-type formulae for backbones, the split reactions are still fully balanced, and no confusion why these backbones have unconventional formulae

@feiranl
Copy link
Collaborator

feiranl commented May 28, 2018

@BenjaSanchez @edkerk I prefer the second option if standing at the point of testing unbalanced reaction and metabolites.

all backbones are now indicated as such.
@BenjaSanchez
Copy link
Contributor Author

@feiranl @edkerk the word backbone has been included in all corresponding metabolites in the latest commit. Let me know if there is anything else pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new field/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants