Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/rxnConfidenceScores #120

Merged
merged 2 commits into from
Jun 7, 2018
Merged

fix/rxnConfidenceScores #120

merged 2 commits into from
Jun 7, 2018

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

Remade function for defining confidence scores, which fixed 38 scores (most of them from pseudoreactions)

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

Remade function for defining confidence scores, which fixed 38 scores (most of them from pseudoreactions)
@edkerk
Copy link
Member

edkerk commented Jun 7, 2018

To avoid confusion, you might want to modify the commented text in the addConfidenceScores, to make clear that scores are positive:

% Reactions with pubmedID and with gene information -3 --> % Reactions with pubmedID and with gene information: 3

@BenjaSanchez
Copy link
Contributor Author

@edkerk thanks for the feedback, I included it in the latest commit :)

@BenjaSanchez BenjaSanchez merged commit 831d245 into devel Jun 7, 2018
@BenjaSanchez BenjaSanchez deleted the fix/rxnConfidenceScores branch June 18, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants