Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update COBRA #131

Merged
merged 1 commit into from
Jul 4, 2018
Merged

chore: update COBRA #131

merged 1 commit into from
Jul 4, 2018

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

No content changes (.txt & .yml don't change), only the order of the bqbiol:is and bqbiol:isDescribedBy qualifiers in the .xml file due to the latest COBRA changes in their export (opencobra/cobratoolbox#1266 I think). @tpfau is this an expected change in the .xml output?

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

no content changes, only order of the fields in the .xml file
@BenjaSanchez BenjaSanchez added the format fix things associated to format of any of the model/data/script files label Jul 3, 2018
@BenjaSanchez BenjaSanchez self-assigned this Jul 3, 2018
@tpfau
Copy link
Contributor

tpfau commented Jul 3, 2018

Yes this is expected.
To be more precise, the Toolbox will, from now on do the following with an SBML model:
Upon reading the model, any model is bioqualifier will be converted to a isDerivedFrom qualifier. This is because the Toolbox does not read everything (e.g. annotations are just those defined by cvterms).
Upon writing, any isInstanceOf or hasPart etc modifiers will be removed if no is modifier was set.
There is a simple reason behind this:
Once we read it, the model is no longer the same, as such we don't know whether it will still has these properties. So we remove them, as inaccurate information is worse than no information (in my opinion).
If a user actively set the is modifier, we assume that he knows what he is doing and does also care about the other annotations.
There is a convenience Method addMIRIAMAnnotations added to the toolbox which can be used to add and update annotations.

@BenjaSanchez BenjaSanchez merged commit b650012 into devel Jul 4, 2018
@BenjaSanchez BenjaSanchez deleted the chore/COBRAupdate branch July 13, 2018 09:31
@BenjaSanchez BenjaSanchez mentioned this pull request Jul 13, 2018
@BenjaSanchez BenjaSanchez added routine Update of toolboxes that lead to (small) model changes and removed format fix things associated to format of any of the model/data/script files labels Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
routine Update of toolboxes that lead to (small) model changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants