Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saveYeastModel #152

Merged
merged 1 commit into from
Sep 3, 2018
Merged

fix: saveYeastModel #152

merged 1 commit into from
Sep 3, 2018

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

Minor changes to saveYeastModel.m:

  • removing spaces in model.rxnECNumbers is no longer necessary
  • model.grRules is now deleted to avoid conflicts with model.rules
  • added some documentation

@feiranl any other suggestions to make the process of saving the model smoother?

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

* removing spaces in rxnECNumbers is no longer necessary
* model.grRules is now deleted to avoid conflicts
* added doc
@BenjaSanchez BenjaSanchez added the format fix things associated to format of any of the model/data/script files label Aug 31, 2018
@BenjaSanchez BenjaSanchez self-assigned this Aug 31, 2018
@feiranl
Copy link
Collaborator

feiranl commented Aug 31, 2018

Great!

@BenjaSanchez BenjaSanchez merged commit a9614c6 into devel Sep 3, 2018
@BenjaSanchez BenjaSanchez mentioned this pull request Sep 3, 2018
@BenjaSanchez BenjaSanchez deleted the fix/saveYeastModel branch September 10, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format fix things associated to format of any of the model/data/script files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants