fix-met.prop: correct metFormulas #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the list of metabolites that previously had no formulas. ardicdavis and I found formulas for some metabolites and furthermore added metabolite ids, and sources.
* remove rows with no formulas (redundant) * remove undesired ' characters * some bugs in function
as complex carbohydrates have varying length, it's best to use the monomeric form
BenjaSanchez
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
@wtscott31 Thank you for the contribution! I added my edits and now looks good to merge. Note that for glycogen & mannan I replaced your proposed formulas for the monomeric forms (i.e. glucose & mannose, respectively), as we used those molecular weights for computing the abundances [mmol/gDW] in the biomass pseudo-reaction. It's also the proper way if we wish to aim for mass balances in the reactions that produce them.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
This improves and updates the metabolites within the model that previously did not have formulas. The formulas were identified and classified with corresponding sources for some metabolites and furthermore listed with associated metabolite IDs.
I hereby confirm that I have:
develas a target branch (top left drop-down menu)