Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add UniProt identifiers #349

Merged
merged 3 commits into from
Aug 22, 2023
Merged

feat: add UniProt identifiers #349

merged 3 commits into from
Aug 22, 2023

Conversation

cheng-yu-zhang
Copy link
Collaborator

@cheng-yu-zhang cheng-yu-zhang commented Aug 4, 2023 •
edited
Loading

Main improvements in this PR:

All files and codes are in yeast-GEM/add_uniprot_id.

  1. get_uniprot_id.py is for getting uniprot ids from the uniprot website.
  2. SGD_with_Uniprot.csv is the output of get_uniprot_id.py with gene names and its uniprot ids.
  3. SGDgeneNames.tsv is originally in yeast-GEM/data/database.
  4. addUniprotID.m was used to add uniprot ids into yeast-GEM.

I hereby confirm that I have:

  • Selected develop as a target branch (top left drop-down menu)

feiranl
feiranl reviewed Aug 5, 2023
View reviewed changes
model/yeast-GEM.yml Outdated Show resolved Hide resolved
@edkerk edkerk changed the base branch from main to develop August 19, 2023 14:09
edkerk
edkerk approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@edkerk edkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased the PR to develop, refactored the code to use RAVEN's editMiriam and removed duplicate SGDgeneNames.tsv. Otherwise, LGTM.

feiranl
feiranl approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edkerk edkerk changed the title add uniprot id feat: add UniProt identifiers Aug 22, 2023
@edkerk edkerk merged commit 4cc1498 into develop Aug 22, 2023
1 check passed
@edkerk edkerk deleted the add-uniprot-id branch August 22, 2023 16:12
@edkerk edkerk linked an issue Oct 16, 2023 that may be closed by this pull request
feat: Uniprot annotations for all genes #320
Closed
4 tasks
@edkerk edkerk mentioned this pull request Oct 16, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edkerk edkerk edkerk approved these changes

@feiranl feiranl feiranl approved these changes

@hongzhonglu hongzhonglu Awaiting requested review from hongzhonglu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Uniprot annotations for all genes
3 participants
@cheng-yu-zhang @edkerk @feiranl