Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hash mismatch with yawsso version 0.7.2 #3

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix hash mismatch with yawsso version 0.7.2 #3

merged 1 commit into from
Jul 5, 2022

Conversation

SergeyMokhov
Copy link
Contributor

Fix for hash mismatch described in issue #2

IevgeniiB
IevgeniiB approved these changes Jun 30, 2022
View reviewed changes
Copy link

@IevgeniiB IevgeniiB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@pguillebert
Copy link

Hi! can we merge this PR? the homebrew install is still broken. Thank you 🙏

@SergeyMokhov
Copy link
Contributor Author

🙏🏻

You are the only one with write permission for the repo, could you merge please?

@IevgeniiB
Copy link

🙏🏻

You are the only one with write permission for the repo, could you merge please?

@SergeyMokhov If this is addressed to me (judging from the emoji) - I don't. I think everyone has "approve" permissions 🤷🏻

@SergeyMokhov
Copy link
Contributor Author

@IevgeniiB in order for my changes to be available to people who installed yawsso using your repository, someone with write permissions to your repository have to merge my pull request into your repository master branch. At the moment, I believe it is just you.

How to merge
Repository permissions

@IevgeniiB
Copy link

@SergeyMokhov It is not my repository. I believe it belongs to @SyncDK. Please direct your questions to them.

@Systemmanic Systemmanic merged commit a8c6e59 into Systemmanic:main Jul 5, 2022
@SergeyMokhov
Copy link
Contributor Author

@IevgeniiB Sorry my friend, your are right.

@SergeyMokhov It is not my repository. I believe it belongs to @SyncDK. Please direct your questions to them.

@SyncDK could you please merge?

@Systemmanic
Copy link
Owner

Systemmanic commented Jul 5, 2022 •
edited
Loading

Sorry for the delay in getting this merged. Life stuff.

@Systemmanic Systemmanic self-assigned this Jul 5, 2022
@SergeyMokhov
Copy link
Contributor Author

SergeyMokhov commented Jul 5, 2022 •
edited
Loading

Sorry for the delay in getting this merged. Life stuff.

@SyncDK Whatever it is, I hope everything gets better sooner 🙏

@SergeyMokhov SergeyMokhov deleted the patch-1 branch July 5, 2022 16:56
@Systemmanic
Copy link
Owner

Systemmanic commented Jul 5, 2022 •
edited
Loading

Hold up this is actually wrong. Nope, it was right.

@Systemmanic Systemmanic mentioned this pull request Jul 5, 2022
Merged
@Systemmanic
Copy link
Owner

Sorry for the delay in getting this merged. Life stuff.

@SyncDK Whatever it is, I hope everything gets better sooner 🙏

Thank you my friend, and appreciate your patience while I butchered this update 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IevgeniiB IevgeniiB IevgeniiB approved these changes

Assignees

@Systemmanic Systemmanic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergeyMokhov @pguillebert @IevgeniiB @Systemmanic