Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump core-styles & use its django-cms-forms #678

Merged
merged 10 commits into from
Nov 27, 2023
Merged

feat: bump core-styles & use its django-cms-forms #678

merged 10 commits into from
Nov 27, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 31, 2023 •
edited
Loading

Status

Overview

TACC/Core-Styles@v2.15.0 loads django-cms-forms.css (in core-styles.base.css via c-form)1, so do not duplicate it.

Related

Changes

  • remove django-cms-forms styles
  • load core-styles version that provides djangocms-cms-forms1

Testing

  1. Deploy on Frontera (Pre-Prod) and APCD (Staging) and TACC (Dev).
  2. Verify the following forms look as they did before.

UI

TACC

Uses Django CMS Form plugin.

Form Before After
Help before after

Frontera

Uses Django CMS Form plugin.

Form Before After
TUP-230 tup-230 230
TUP-320 tup-320 320
Sal Test Form sal test form sal

APCD

Untested

Uses Django CMS Form markup. Sad story.

Form Before After
Request to Submit request to submit …
Threshold Exception threshold exception …
Extension Request extension request …

Notes

Core-Styes v12–14 do not include any breaking changes.

Footnotes

  1. Because it seems easier to support via Core-Styles than in isolation in Core-CMS. Because Core-Styles uses c-form for s-form and djaango-cms-forms in a DRY manner that I only see becoming redundant if maintained in Core-CMS. Questions and ideas welcome. Form CSS is easy to refactor now. ↩ ↩2

@wesleyboar
feat: bump core-styles & use its django-cms-forms
7693b33 
Core-Styles v2.15 provides django-cms-forms via `core-styles.base.css`.

Core-Styes v12–14 do not include any breaking changes.
@wesleyboar wesleyboar mentioned this pull request Jul 31, 2023
Merged
@wesleyboar wesleyboar added the blocked Unable to continue work label Jul 31, 2023
@wesleyboar wesleyboar changed the title feat: bump core-styles & use its django-cms-forms feat: bump core-styles to v2.15 & use its django-cms-forms Jul 31, 2023
@wesleyboar wesleyboar mentioned this pull request Aug 15, 2023
Closed
@wesleyboar wesleyboar added feature A new feature or replacement of present feature and removed blocked Unable to continue work labels Sep 1, 2023
@wesleyboar wesleyboar changed the base branch from main to feat/core-styles-v2-19-0 November 27, 2023 15:49
@wesleyboar wesleyboar changed the title feat: bump core-styles to v2.15 & use its django-cms-forms feat: bump core-styles & use its django-cms-forms Nov 27, 2023
@wesleyboar
feat: load django-cms-forms.css from core-styles
0335d90 
Core-Styles loads shared form styles via c-form.

Those shared styles to apply to Django CMS Forms.

But django-cms-forms.css has specific custom styles CMS needs.
wesleyboar added a commit to TACC/tup-ui that referenced this pull request Nov 27, 2023
@wesleyboar
feat: core-cms w/ core-styles' django-cms-forms
c7d3a70 
TACC/Core-CMS#678 since 0335d90.
wesleyboar added a commit to TACC/tup-ui that referenced this pull request Nov 27, 2023
@wesleyboar
fix: core-cms core-styles' django-cms-forms
d23a92c 
TACC/Core-CMS#678 (latest as of now)
@wesleyboar wesleyboar merged commit 71bdb4c into feat/core-styles-v2-19-0 Nov 27, 2023
@wesleyboar wesleyboar deleted the feat/core-styles-update branch November 27, 2023 21:22
@wesleyboar wesleyboar mentioned this pull request Nov 27, 2023
Merged
wesleyboar added a commit that referenced this pull request Nov 28, 2023
@wesleyboar
feat: update core-styles from v2.11 to v2.22 (#742)
a989be0 
* feat: update Core-Styles from v2.11 to v2.19

* feat: core-styles v2.19 to v2.20

* feat: core-styles v2.20 to v2.21

* feat: core-styles v2.21.0 to v2.21.1

* feat: core-styles v2.21.1 to v2.21.2

* feat: core-styles v2.21.1 to v2.22.0

* feat: bump core-styles & use its django-cms-forms (#678)

* feat: bump core-styles & use its django-cms-forms

Core-Styles v2.15 provides django-cms-forms via `core-styles.base.css`.

Core-Styes v12–14 do not include any breaking changes.

* feat: load django-cms-forms.css from core-styles

Core-Styles loads shared form styles via c-form.

Those shared styles to apply to Django CMS Forms.

But django-cms-forms.css has specific custom styles CMS needs.

* fix: django-cms-forms.css (core-styles ~2.22.1)

* fix: django-cms-forms.css (core-styles) not built

* docs: fix djangocms_forms comment/redirect typo

* Revert "fix: django-cms-forms.css (core-styles) not built"

This reverts commit c07ec5b.

* fix: django-cms-forms.css (core-styles) not built
wesleyboar added a commit to TACC/tup-ui that referenced this pull request Nov 30, 2023
@wesleyboar @R-Tomas-Gonzalez
feat: tup-463 migrate css to core (#344)
eb3f7f0 
* docs: more css thoughts in comment

* docs: more css thoughts in comment

* feat: tup-619 c-content block migration (#346)

* feat: tup-619 c-content block migration

* removed content-block import

* feat: tup-623 c-update migration (#348)

* migrated c-update to core-styles

* removed c-update import

* feat: tup-624: added generics/attributes to demo (#345)

* feat: tup-624: added generics/attributes to demo

* migrated rest of attributes.css to core-styles

* removed unnecessary comments in css file for c-button

* feat/tup-625: Migrate o-heading-steps to core-styles (#349)

* feat/tup-630: Migrate django.cms.blog.app.item (#351)

* getting rid of django.cms.blog.app.item.css

* removing the import for django.cms.blog.app.item.css

* feat/tup-632: Migrate django.cms.picture.css to core-cms (#355)

* Migrate c-card fixes to core-styles (#361)

Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>

* Migrated header to Core-Styles (#359)

Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>

* fix: tup-617 c-button font-weight redunant style (#364)

* feat(tup-cms): core-cms with core-styles v2.19

* chore: lowercase comment

* feat(tup-cms)!: core-cms with core-styles v2.19

WARNING: v2.17.3 causes login form field bug.

* feat/tup-634: Migrate pseudo-elements to core-cms (#358)

* feat/tup-625: delete u-highlight stylesheet (#352)

No need for u-highlight per jira ticket

Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>

* Migrate card list support to core-styles (#360)

Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>

* feat/tup-626: delete o-section from tup-ui (#353)

* I believe this has already been merged into core-styles... Padding and Margin seem to be available on prod

* remove import of core-styles o-heading-steps.css

* feat/tup-633: Migrate lightgallery to core-cms (#357)

* feat/tup-633: Migrate lightgallery to core-cms

* delete unnecessary import of django.cms.picture.css

* feat/tup-629: delete footer (#356)

* feat/tup-629: delete footer

Footer is already in core-styles and cms

* remove unnecessary imports

* removing all card--image styles (#365)

* chore: tup-616 migrate c-button styles to core-cms (#343)

* chore: migrate c-button styles to core-cms

TACC/Core-CMS#729

* fix: remove import of file deleted in merge

---------

Co-authored-by: Tomas Gonzalez <tgonzalez@tacc.utexas.edu>

* feat/tup-622 migrate c-pill to core-styles (#367)

* feat/tup-640 Delete c-card and c-content-block imports (#368)

* feat(tup-cms): core-cms with core-styles v2.20

WARNING: Introduces login form field width bug. (Core-Styles v2.17.3 might be the cause.)

* feat(tup-ui): core-styles v2.20

* feat(tup-cms): core-styles v2.21 + via core-cms

* feat: tup 648 do not use plain highlight class (#370)

* feat: tup-648 do not use plain highlight class

* feat: tup-648 do not use plain highlight class

* bug/tup-650: Resetting (unset) padding-block from cms (#371)

* bug/tup-650: Remove padding-block from cms

* adjusted comments to relative code blocks

* fix: tup-654 use c-form--login from core-styles (#374)

* fix: tup-654 use c-form--login from core-styles

* chore: tup-654 remove redundant `c-form` classname

* chore: tup-463 remove temp. core-styles imports (#375)

Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet.

Now CMS has much more recent Core-Styles, so use them. Do not duplicate.

* enhance: tup-463 login component should use core-styles (#376)

* chore: tup-463 remove temp. core-styles imports

Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet.

Now CMS has much more recent Core-Styles, so use them. Do not duplicate.

* chore: tup-463 delete css modules mimicking core

Some Core-Styles CSS was added after TUP login form was developed.

Now that it is available, TUP lofin form can use it. Less module CSS!

* style: npx nx format:write

* chore: tup-463 delete css modules mimicking core (#377)

Some Core-Styles CSS was added after TUP login page was developed.

Now that it is available, TUP login page can use it. Less module CSS!

* feat: core-styles v2.21.0 to v2.21.1

* feat: core-cms, core-styles v2.21.0 to v2.21.1

* hotfix: tup-654 mfa c nav pipe not showing (#379)

* hotfix: tup-654 mfa's c-nav not showing a pipe

1. There should be a pipe (border) between nav links.
2. The `c-button--as-link` nav link's pipe was present but invisible.
3. c-button x-truncate `overflow: hidden` overwrote `overflow: visible`.
4. It should be the other way around.
5. Composing c-button from dist/ includes entire file into global scope.
6. Isntead, compose from src, to get only what is necessary.

* hotfix: tup-654 mfa's c-nav not showing a pipe

1. There should be a pipe (border) between nav links.
2. The `c-button--as-link` nav link's pipe was present but invisible.
3. c-button x-truncate `overflow: hidden` overwrote `overflow: visible`.
4. It should be the other way around.
5. Importing c-form--login without layer gave it precedence.
6. Instead, import into base layer, so all Core-Styles are in base.

* chore: remove redundant import of cortal.icon.css (#380)

The core-styles.portal.css already includes cortal.icon.css.

* hotfix: tup-658 login form title too small (#381)

* hotfix: tup-658 form login title too small

* docs: idea, Core-Styles elements/headings--portal

* feat: core-cms, core-styles v2.21.1 to v2.21.2

* feat: core-cms, core-styles v2.21 to v2.22

* feat: core-cms w/ core-styles' django-cms-forms

TACC/Core-CMS#678 since 0335d90.

* fix: core-cms core-styles' django-cms-forms

TACC/Core-CMS#678 (latest as of now)

* feat: tup-463 migrate css to core - misc bugs (#384)

* chore: search dropdown should use var for white

* fix: footer buttons should not have width limit

* refactor: deprecate `<small>` in footer buttons

* fix!: do not let search styles bleed beyond search

Requires an `id="tacc-google-search` wrapper.

* fix: remove unnecessary style

The only `<h1>` on the page is "Search" text provided by CMS not Google.

* docs: explain strange, complex search css selector

* fix: core-styles v2.22.0 to v2.22.1

* chore: core-styles v2.22.1 to v2.22.2

* chore: core-cms v4.2.0

---------

Co-authored-by: Tomas Gonzalez <63771558+R-Tomas-Gonzalez@users.noreply.github.com>
Co-authored-by: Tomas Gonzalez <tgonzalez@tacc.utexas.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature A new feature or replacement of present feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar