Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP-1648: Build Individual Stylesheets — ⚠️ API Change #23

Merged
merged 5 commits into from
May 25, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 15, 2022

Overview

Allow consuming and/or building* individual stylesheets.
  • (for clients that only consume)
    Build all stylesheets and commit dist/ directory (for Portal).
  • (for clients building from source)
    Let clients (and this repo itself now) build individual files (theirs, ours, both).*

* CMS is the only client app that does, and is expected to, build its styles via the Core-Styles build command.

Related

Changes

Top of diff and bottom of diff have the most relevant changes. In between is all dist/.

  • e00d6b8 let user match pattern, drop --file-ext
  • ef2db2b build all stylesheets and commit dist/
  • 12f1484 use --input/--ouput not --input-dir/--output-dir
  • c543a07 allow build with custom glob input
  • update .gitignore

Testing

  1. Build all styles internally via npm run build.
    • Verify all are added in the same sub-dirs as source/_imports/.
    • Verify dist/tools/ stylesheets have either class selectors (.bob) or functional selectors (%bob), not both.
  2. Test all styles internally via npm run test (builds output of plugin tests).
    • Verify build output in dist/_tests/.
  3. Test https://github.com/TACC/Core-CMS/pull/489/files.

Screenshots

N/A

@wesleyboar wesleyboar changed the title Task/fp 1648 build all files and commit dist/ Task/fp 1648 build all files, commit dist/, change API May 17, 2022
@wesleyboar wesleyboar changed the title Task/fp 1648 build all files, commit dist/, change API Styles: Build Individual Stylesheets — API Change! May 23, 2022
@wesleyboar wesleyboar changed the title Styles: Build Individual Stylesheets — API Change! FP-1648: Build Individual Stylesheets (⚠️ API Change) May 23, 2022
@wesleyboar wesleyboar changed the title FP-1648: Build Individual Stylesheets (⚠️ API Change) FP-1648: Build Individual Stylesheets — ⚠️ API Change May 23, 2022
@wesleyboar
Copy link
Member Author

Merging based on approval of TACC/Core-CMS#489 which is on the only repo using the Core-Styles CLI.

@wesleyboar wesleyboar merged commit 0cc819a into main May 25, 2022
@wesleyboar wesleyboar deleted the task/fp-1648-build-all-files-and-commit-dist branch May 25, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant