Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tup-615 flexible space on dashboard #342

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Oct 10, 2023

Overview

Remove excess space above Dashboard header text.

Related

Changes

  • added css to shrink header

Testing

  1. Open Dashboard.
  2. Make window wide (≥1200px) and tall (≥980px).
  3. Verify "Dashboard" header text only has 15px of space above it.

UI

before after
before after

detail

@wesleyboar wesleyboar changed the title feat: tup-615 small header buttons (#338) fix: tup-615 flexible space above dashboard header Oct 10, 2023
@wesleyboar wesleyboar merged commit 25e10b9 into fix/tup-615-header-spacing-consistency Oct 10, 2023
1 check passed
@wesleyboar wesleyboar deleted the fix/tup-615-header-spacing-consistency--odd-dashboard-header-layout branch October 10, 2023 21:25
@wesleyboar wesleyboar changed the title fix: tup-615 flexible space above dashboard header fix: tup-615 flexible space on dashboard Oct 10, 2023
wesleyboar added a commit that referenced this pull request Nov 14, 2023
* feat: tup-615 small header buttons (#338)

* feat: tup-615 my account header (#340)

* fix: inconsistent header spacing (#341)

* fix: tup-615 flexible space above dashboard header (#342)

* fix: project ticket grid too much middle space

Designers do not intend nor like big gap. It's been around since Portal.

But it's been so difficult to fix… until  `project-ticket-grid` came.

I hadn't noticed the fix was possible until just now.

* docs: more css thoughts in comment

* docs: more css thoughts in comment

* feat: tup-619 c-content block migration (#346)

* feat: tup-619 c-content block migration

* removed content-block import

* feat: tup-623 c-update migration (#348)

* migrated c-update to core-styles

* removed c-update import

* feat: tup-624: added generics/attributes to demo (#345)

* feat: tup-624: added generics/attributes to demo

* migrated rest of attributes.css to core-styles

* removed unnecessary comments in css file for c-button

* feat/tup-625: Migrate o-heading-steps to core-styles (#349)

* feat/tup-630: Migrate django.cms.blog.app.item (#351)

* getting rid of django.cms.blog.app.item.css

* removing the import for django.cms.blog.app.item.css

* feat/tup-632: Migrate django.cms.picture.css to core-cms (#355)

* Migrate c-card fixes to core-styles (#361)

Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>

* Migrated header to Core-Styles (#359)

Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>

* fix: tup-617 c-button font-weight redunant style (#364)

* feat(tup-cms): core-cms with core-styles v2.19

* chore: lowercase comment

* feat(tup-cms)!: core-cms with core-styles v2.19

WARNING: v2.17.3 causes login form field bug.

* feat/tup-634: Migrate pseudo-elements to core-cms (#358)

* feat/tup-625: delete u-highlight stylesheet (#352)

No need for u-highlight per jira ticket

Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>

* Migrate card list support to core-styles (#360)

Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>

* feat/tup-626: delete o-section from tup-ui (#353)

* I believe this has already been merged into core-styles... Padding and Margin seem to be available on prod

* remove import of core-styles o-heading-steps.css

* feat/tup-633: Migrate lightgallery to core-cms (#357)

* feat/tup-633: Migrate lightgallery to core-cms

* delete unnecessary import of django.cms.picture.css

* feat/tup-629: delete footer (#356)

* feat/tup-629: delete footer

Footer is already in core-styles and cms

* remove unnecessary imports

* removing all card--image styles (#365)

* chore: tup-616 migrate c-button styles to core-cms (#343)

* chore: migrate c-button styles to core-cms

TACC/Core-CMS#729

* fix: remove import of file deleted in merge

---------

Co-authored-by: Tomas Gonzalez <tgonzalez@tacc.utexas.edu>

* feat/tup-622 migrate c-pill to core-styles (#367)

* fix: tup-615 prevent too tall proj's-tickets table

* feat/tup-640 Delete c-card and c-content-block imports (#368)

* feat(tup-cms): core-cms with core-styles v2.20

WARNING: Introduces login form field width bug. (Core-Styles v2.17.3 might be the cause.)

* feat(tup-ui): core-styles v2.20

---------

Co-authored-by: Tomas Gonzalez <63771558+R-Tomas-Gonzalez@users.noreply.github.com>
Co-authored-by: Jake Rosenberg <jrosenberg@tacc.utexas.edu>
Co-authored-by: Tomas Gonzalez <tgonzalez@tacc.utexas.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant