feat: TUP-700 @tacc/core-components - wrappers #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. import & use `dts`
- Fixes build error:
> error TS2307: Cannot find module './….module.css' or its corresponding type declarations.
> … import styles from './….module.css';
2. `"composite": true`
- Fixes Typescript lint error:
> Referenced project '/…/tup-ui/libs/core-components/tsconfig.lib.json' must have setting "composite": true.
3. `"declaration": true,`
- Seemingly caused by `"composite": true`.
- Fixes Vite build error:
> \> nx run core-components:build:production
> error TS6304: Composite projects may not disable declaration emit.
"So the consuming application is aware that it must have React installed to use this package." — https://dev.to/receter/how-to-create-a-react-component-library-using-vites-library-mode-4lma#dependencies
"To prevent the CSS files from being accidentally removed by the consumer's tree-shaking efforts…" —https://dev.to/receter/how-to-create-a-react-component-library-using-vites-library-mode-4lma#side-effects
Move the changes from thsoe commits to be in core-components package.json, not root package.json.
- style: tup-700 peerDependencies
"So the consuming application is aware that it must have React installed to use this package."
— https://dev.to/receter/how-to-create-a-react-component-library-using-vites-library-mode-4lma#dependencies
- feat: tup-700 add CSS as sideEffects
"To prevent the CSS files from being accidentally removed by the consumer's tree-shaking efforts…"
— https://dev.to/receter/how-to-create-a-react-component-library-using-vites-library-mode-4lma#side-effects
- feat: tup-700 ensure build before publish
Resolve all commented code in `vite.config.ts`.
- `outDir` DELETED cuz `rollupOptions` > `output` exists
- `reportCompressedSize` RESTORED cuz why not & it was already there
- `commonjsOptions` & `transformMixedEsModules` DELETED cuz…
- no `require` i.e. common js modules
- `lib`'s `name` and `fileName` DELETED cuz…
- `rollupOptions` > `output` > `assetFileNames` exists
- `rollupOptions` > `output` > `entryFileNames` exists
…CC/tup-ui into feat/TUP-700-core-components-node-pkg
Only 1 root package-lock.json in an Nx project such as tup-ui. Having this may have been cause of errors when starting CMS.
…0-core-components-node-pkg--wrappers
Because the distinction between them is not accurate. Both have components that import other components.
This causes more work when renaming a library.
These references are outside of this lib, so yeah, reference lib name.
…0-core-components-node-pkg--wrappers
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
Base automatically changed from
feat/TUP-700-core-components-node-pkg
to
epic/TUP-700-core-components-node-pkg
May 16, 2024 18:01
5 tasks
…0-core-components-node-pkg--wrappers
wesleyboar
merged commit 9e6af47
into
epic/TUP-700-core-components-node-pkg
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Merge
libs/core-wrapperstolibs/core-components.Related
core-wrappersto feat: TUP-700 @tacc/core-components - package #433Changes
core-wrapperscomponentscore-wrapperscomponents tocore-componentscore-wrapperscomponent dependencies tocore-componentspeerDep…sTesting & UI
Run
tup-uinpm cilibs/core-wrappersstill work, like Formik.Build
core-compoenntsnpm cinpx nx build core-components --skip-nx-cacheLog
Serve
ui-patternsnpm cinpx nx serve ui-patterns --skip-nx-cacheUI
tup-uiui-patterns(top)*ui-patterns(end)** ui-patterns (full)