Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RT-99514 unique state for suspended user #472

Merged
merged 7 commits into from
Jul 26, 2024
Merged

fix: RT-99514 unique state for suspended user #472

merged 7 commits into from
Jul 26, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 26, 2024 •
edited
Loading

Overview

Tell user if there account is suspended. Direct them to TAM.

Related

Changes

  • add new error code to <LoginError>

Testing

  1. Render the error. Options:
    • Try to login with suspended account.
    • Fake a 451 response from server.
    • Enter bad credentials, then edit error markup.
  2. Verify login form shows error about account suspension.
  3. Verify error has working link to https://accounts.tacc.utexas.edu/login_support.

UI

balanced (a290672)
RT 99514 Solution Proposal - Balanced
Archived
terse (f037ced) nice (07039b0)
RT 99514 RT 99514 Solution Proposal - Nicer

Notes

  • @jarosenb can provide specific error code for this state.
  • Designers have taught me not to use Please or Thank you in messages (example article).1
  • An existing message uses "Please" and "Sorry", so I mimic.

Footnotes

  1. Simply let user know what happened, and what to do, politely. ↩

@wesleyboar
fix: RT-99514 suspended user needs unique state
1eec5da
@wesleyboar
fix: RT-99514 more specific error
4008f22
@wesleyboar
fix: RT-99514 error should not be polite
7e0bfff 
TACC portal designers often remind me that we should not say please or sorry or thank you. Jsut tell the user what happenned and what to do.
@wesleyboar
fix: RT-99514 unnecessary new line
f037ced
@wesleyboar wesleyboar requested a review from jarosenb July 26, 2024 19:33
@jarosenb jarosenb merged commit 3c871cd into main Jul 26, 2024
1 check passed
@jarosenb jarosenb deleted the fix/rt-99514-unique-state-for-suspended-user branch July 26, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarosenb jarosenb jarosenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @jarosenb