Compatibility with custom dataset #58
Conversation
|
@roskamsh Hello there! How are we doing around here? Is it ready for review? When ready you can add me as a reviewer on all your PRs :) |
|
@olivierlabayle this should be ready to review. The only thing I need to do is update the docs regarding how the setup slightly changes in regards to parameters in the nextflow.config but I believe that is on a separate branch? |
Amazing I'll start to look at the code then ! Ideally, we can do it on the same branch so that the PR is self contained. |
There was a problem hiding this comment.
Thank you Breeshey for your work here. Appart from my comment on the script this looks good to me and the tests pass. Before merging we need to add one test for this new scenario and add some documentation. Happy to discuss that further :)
Todo:
- Add test
- Update docs
Conflicts: .gitignore conf/ci_jobs/from_actors.config conf/ci_jobs/from_param_file.config main.nf modules/genotypes.nf
|
To-do checklist has now been completed. |
… into brh_data_source
|
@roskamsh I've updated the new test configuration filename to match what it does, if the tests work, I'll merge and release! Thank you again for taking the time! :-) |
This branch was created to make the targene-pipeline compatible with datasets that are not the UKBB.