Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

[Hacktoberfest] Create Your Own TikTok Video About VCs #1861

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

breehall
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ New Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 👷 Example Application
  • 🧑‍💻 Code Snippet
  • 🎨 Design
  • 📖 Content
  • 🧪 Tests
  • 🔖 Release
  • 🚩 Other - Hacktoberfest

Description

This PR adds an entry inside of externalContributors.json which links to a TikTok I created on VCs for Hacktoberfest

Related Tickets & Documents

Resolves #1731

Mobile & Desktop Screenshots/Recordings

N/A

Added code snippets?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

No tests? Add a note

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 general documentation
  • 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

Spongebob & Patrick

Copy link

netlify bot commented Oct 30, 2024

👷 Deploy request for tbd-website-developer-new pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1066d30

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for tbd-website-developer ready!

Name Link
🔨 Latest commit 1066d30
🔍 Latest deploy log https://app.netlify.com/sites/tbd-website-developer/deploys/67222f7900161f0008cc3874
😎 Deploy Preview https://deploy-preview-1861--tbd-website-developer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taniashiba
Copy link
Contributor

taniashiba commented Oct 30, 2024

@breehall Your video came out amazing! Thank you so much! Our team will be sure to review/merge ASAP 🖤

Copy link
Contributor

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @breehall! I love your video. My team is raving about it in Slack. Your thumbnail isn't showing up because you need to add a / in front of the word img so it can get the correct path. And this is a nitpick, but do you mind switching the type to say video instead of social? After that, i can merge and approve.

@breehall
Copy link
Contributor Author

@blackgirlbytes no worries! I just update the URL to include the / and the type for the contribution as well. Let me know if anything else is needed.
Is there something else wrong in my changes that's causing the Test and Deploy to Netlify / test-js to fail?

@taniashiba I'm so happy you all like it! It was such a fun video to create! 😄

@EbonyLouis
Copy link
Contributor

@breehall no everything is great! Sometimes that test is finicky and we need to rerun it a few times. Your video is so great it inspires me to be a little bit more creative with my shorts.

Copy link
Contributor

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! thank you and merging!

@blackgirlbytes blackgirlbytes merged commit 353bb31 into TBD54566975:main Oct 30, 2024
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Your Own TikTok Video About Verifiable Credentials (VCs)
4 participants