Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker image generation script + minor update to README #154

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

thehenrytsai
Copy link
Member

@thehenrytsai thehenrytsai commented Aug 2, 2024

  1. Updated base image used, 18-buster failed Google store vulnerability check.
  2. For more easily identifying the docker images.
  3. For understanding the tag logic, because current naming is quite misleading.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (f3bdd01) to head (d0c810c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files          28       28           
  Lines        2948     2948           
  Branches      395      395           
=======================================
  Hits         2803     2803           
  Misses        144      144           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is definitely useful when wanting to have different versions of the server without having updated the dwn-sdk-js. Will be useful when I wire our DWN instances to have a latest that's different from beta.

Just one sanity comment.

.github/workflows/docker-image-publish.yml Show resolved Hide resolved
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🐐

@thehenrytsai thehenrytsai merged commit 4c9d44a into main Aug 3, 2024
8 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/docker-tags branch August 3, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants