Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtocolURI path component in DRLs MUST be base64url encoded #168

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Sep 19, 2024

Through testing apps and DRLs we've concluded that base64url encoding the protocol URI in the path segments is best.

We particularly ran into this issue with nginx https://trac.nginx.org/nginx/ticket/786 where nginx decides to decode then re-encode the path segment which removes one of the slashes from the protocol URI.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 80.32787% with 12 lines in your changes missing coverage. Please review.

Project coverage is 94.92%. Comparing base (295be4a) to head (5f9f2ff).

Files with missing lines Patch % Lines
src/http-api.ts 80.32% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   94.89%   94.92%   +0.03%     
==========================================
  Files          28       28              
  Lines        2956     2976      +20     
  Branches      397      401       +4     
==========================================
+ Hits         2805     2825      +20     
  Misses        150      150              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiranCohen LiranCohen force-pushed the lirancohen/decode-protocol-path-component branch from fc33650 to 629d083 Compare September 19, 2024 20:07
@LiranCohen LiranCohen changed the title decode protocol from path component ProtocolURI path component in DRLs MUST be base64url encoded Sep 19, 2024
@LiranCohen LiranCohen force-pushed the lirancohen/decode-protocol-path-component branch from 629d083 to c9b92e8 Compare September 19, 2024 20:21
csuwildcat
csuwildcat previously approved these changes Sep 19, 2024
@LiranCohen LiranCohen merged commit 1e931e5 into main Sep 19, 2024
8 checks passed
@LiranCohen LiranCohen deleted the lirancohen/decode-protocol-path-component branch September 19, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants