Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming crypto algorithms #16

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Renaming crypto algorithms #16

merged 2 commits into from
Feb 16, 2024

Conversation

amika-sq
Copy link
Contributor

Here we go again :P

This PR changes names only, and doesn't modify any functionality. The name changes required file name changes, which is why Github is having a really difficult time with the diff here.

This PR does the below renames, as we discussed in our weekly sync:

Renames

  1. EcDSA.ES256K -> Secp256k1
    • This is the AsymmetricKeyGenerator and Signer that performs cryptographic operations using ECDSA with the secp256k1 elliptic curve and SHA-256
  2. EDDSA.Ed25519 -> Ed25519
    • This is the AsymmetricKeyGenerator and Signer that performs cryptographic operations using EdDSA with the Ed25519 curve
  3. CryptoAlgorithm.es256k -> CryptoAlgorithm.secp256k1
    • This is algorithm identifier that can be provided to generatePrivateKey to create a new private key

Copy link
Collaborator

@jiyoonie9 jiyoonie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i understood most of these coz we talked about crypto package earlier! makes sense to me 🎉

@@ -0,0 +1,115 @@
import CryptoKit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why github makes this one look like it's a brand new file 🤔

@amika-sq amika-sq merged commit 4290f12 into main Feb 16, 2024
1 check passed
@amika-sq amika-sq deleted the rename-crypto-algorithm branch February 16, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants