Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery Sensor Devices Should not Be Included in *_All Commands #533

Open
krkeegan opened this issue Nov 12, 2024 · 0 comments
Open

Battery Sensor Devices Should not Be Included in *_All Commands #533

krkeegan opened this issue Nov 12, 2024 · 0 comments
Assignees

Comments

@krkeegan
Copy link
Collaborator

krkeegan commented Nov 12, 2024

This applies to sync_all, refresh_all, join_all and any others

I think our initial thought had been that these messages would be cached for battery devices, but that doesn't seem to work out correctly. I have to revisit why I concluded this isn't working, but the solution was just to skip battery devices in the all commands.

Edit
I remember why this is an issue again.

The command sequence used for the *_all commands runs sequentially. When it hits a battery device, the entire sequence halts until that device wakes up. This isn't ideal as the user doesn't get to see the command run to completion. The command could take ages to run to completion or never happen.

Alternatives
The only alternative I can see are to fire off each request the the battery devices without using a sequence assuming they are asleep.
This isn't ideal as if they are awake the commands will get sent and could collide with each other.

I think they best answer is for the user to call these commands on each battery device as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant