Remove Battery Devices from *_All Commands #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If they are present, the sequence for the *_all command will halt when it gets to a battery device and only resume when that device has woken up and the command was sent. This is at best confusing to the user, because they expect to see the sequence run to completion and receive a message like "Refresh All Devices Complete" At worst, this is problematic if a device after a battery device in the sequence is not getting the proper command and the user assumes that it is.
tstabrawa
reviewed
Nov 14, 2024
Co-authored-by: tstabrawa <59430211+tstabrawa@users.noreply.github.com>
tstabrawa
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I remember why this was an issue and have updated issue #533.
In short battery devices are present, the sequence for the *_all command will halt when it gets to a battery device and only resume when that device has woken up and the command was sent.
This is at best confusing to the user, because they expect to see the sequence run to completion and receive a message like
"Refresh All Devices Complete"
At worst, this is problematic if a device after a battery device in the sequence is not getting the proper command and the user
assumes that it is.
Note
There is an alternative solution in which the commands are sent immediately to battery devices with the assumption that they are asleep and the command will be queued. This seems bad to me as the devices may be awake, in which case they could collide with each other. Also the messages (other than
refreshfor which there is a test) would just pile up in the battery device's queue potentially with numerous duplicates if these were called a lot.Overall, I think they best option is for users to call these commands on each desired battery device directly.
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: