Get account requests by ID in storage update method (#12955)

TEAMMATES · Mar 29, 2024 · 9f0ca34 · 9f0ca34
1 parent 6049c81
commit 9f0ca34
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/it/java/teammates/it/storage/sqlapi/AccountRequestsDbIT.java b/src/it/java/teammates/it/storage/sqlapi/AccountRequestsDbIT.java
@@ -107,8 +107,7 @@ public void testUpdateAccountRequest() throws Exception {
         accountRequest.setName("new account request name");
 
         accountRequestDb.updateAccountRequest(accountRequest);
-        AccountRequest actual = accountRequestDb.getAccountRequest(
-                accountRequest.getEmail(), accountRequest.getInstitute());
+        AccountRequest actual = accountRequestDb.getAccountRequest(accountRequest.getId());
         verifyEquals(accountRequest, actual);
     }
 

diff --git a/src/main/java/teammates/storage/sqlapi/AccountRequestsDb.java b/src/main/java/teammates/storage/sqlapi/AccountRequestsDb.java
@@ -128,7 +128,7 @@ public AccountRequest updateAccountRequest(AccountRequest accountRequest)
             throw new InvalidParametersException(accountRequest.getInvalidityInfo());
         }
 
-        if (getAccountRequest(accountRequest.getEmail(), accountRequest.getInstitute()) == null) {
+        if (getAccountRequest(accountRequest.getId()) == null) {
             throw new EntityDoesNotExistException(
                 String.format(ERROR_UPDATE_NON_EXISTENT, accountRequest.toString()));
         }

diff --git a/src/test/java/teammates/storage/sqlapi/AccountRequestsDbTest.java b/src/test/java/teammates/storage/sqlapi/AccountRequestsDbTest.java
@@ -106,7 +106,7 @@ public void testUpdateAccountRequest_invalidEmail_throwsInvalidParametersExcepti
     public void testUpdateAccountRequest_accountRequestDoesNotExist_throwsEntityDoesNotExistException() {
         AccountRequest accountRequest =
                 new AccountRequest("test@gmail.com", "name", "institute", AccountRequestStatus.PENDING, "comments");
-        doReturn(null).when(accountRequestDb).getAccountRequest(anyString(), anyString());
+        doReturn(null).when(accountRequestDb).getAccountRequest(accountRequest.getId());
 
         assertThrows(EntityDoesNotExistException.class,
                 () -> accountRequestDb.updateAccountRequest(accountRequest));
@@ -118,7 +118,7 @@ public void testUpdateAccountRequest_accountRequestDoesNotExist_throwsEntityDoes
     public void testUpdateAccountRequest_success() throws InvalidParametersException, EntityDoesNotExistException {
         AccountRequest accountRequest =
                 new AccountRequest("test@gmail.com", "name", "institute", AccountRequestStatus.PENDING, "comments");
-        doReturn(accountRequest).when(accountRequestDb).getAccountRequest(anyString(), anyString());
+        doReturn(accountRequest).when(accountRequestDb).getAccountRequest(accountRequest.getId());
 
         accountRequestDb.updateAccountRequest(accountRequest);