Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor edit session page: Fix custom visibility table overflow #12276

Closed
zhaojj2209 opened this issue Mar 28, 2023 · 12 comments · Fixed by #12574
Closed

Instructor edit session page: Fix custom visibility table overflow #12276

zhaojj2209 opened this issue Mar 28, 2023 · 12 comments · Fixed by #12574
Labels
a-UIX User Interface, User eXperience, responsiveness c.Bug Bug/defect report good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.

Comments

@zhaojj2209
Copy link
Contributor

At screen widths of smaller than 400px, the custom visibility table overflows, as shown below:
Screenshot 2023-03-27 at 15 58 04

One way to fix this would be to make the table horizontally scrolling, but it would be good to have the entire table fit within the screen width as well.
@zhaojj2209 zhaojj2209 added good first issue Easy; restricted for first-time contributors c.Bug Bug/defect report p.VeryLow Just cosmetic value only. Do only if we have spare resources. a-UIX User Interface, User eXperience, responsiveness labels Mar 28, 2023
@Mrityunjaydeepak
Copy link

Hey, i would like to work on this!

@weiquu
Copy link
Contributor

weiquu commented Apr 14, 2023

Hi @Mrityunjaydeepak, sure! Feel free to submit a PR for this issue (:

@Oshanik22
Copy link

Can I work on this? I'm a first-time contributor and having some difficulty finding a good issue to start with, so I'm also open to recommendations for working on any other issue.

@zhaojj2209
Copy link
Contributor Author

@Oshanik22 We recommend any of the issues with the good first issue label. Feel free to submit a PR, but if someone else has previously expressed interest in working on the issue, do check with them if they are still working on it first before opening a PR.

Also, as good first issues are for first-time contributors only, note that you can only pick one of them to work on. For subsequent issues, we recommend issues with the help wanted label.

@Oshanik22
Copy link

Hi, @zhaojj2209, thanks for the quick response. @Mrityunjaydeepak are you working on this? If not, I would like to take this up :)

@Mrityunjaydeepak
Copy link

@Oshanik22 yes, you can take it i am currently working on something else.

@Oshanik22
Copy link

thanks

@guivilela7
Copy link

Hi, I'm a first time contributor and would like to work on this issue if possible. @Oshanik22 are you still working on this or could I take it?

@domlimm
Copy link
Contributor

domlimm commented Jun 29, 2023

@guivilela7 Feel free to submit a PR.

@github-actions github-actions bot mentioned this issue Jun 29, 2023
Open
@nncha96
Copy link

nncha96 commented Sep 2, 2023

Is this one still open? Can I work on it?

@github-actions github-actions bot mentioned this issue Sep 2, 2023
Open
@jasonqiu212
Copy link
Contributor

Hi @nncha96, Feel free to submit a PR for this issue!

@RohithSurya
Copy link
Contributor

Hey guys!! I would like to submit a PR for this issue
I found how to fix the issue too

@RohithSurya RohithSurya mentioned this issue Sep 4, 2023
Merged
jasonyong12345 added a commit to jasonyong12345/teammates that referenced this issue Sep 6, 2023
@jasonyong12345
Create [TEAMMATES#12552] Create searchStudentInfo
fdff3c2 
Fixes TEAMMATES#12276
cedricongjh added a commit that referenced this issue Sep 17, 2023
@RohithSurya @jasonqiu212 @cedricongjh
[#12276] Instructor edit session page: Fix custom visibility table ov…
4a39df1 
…erflow (#12574)

* Use responsive-table class to add scrollbar when table overflows

* Update snapshots according to UI changes

---------

Co-authored-by: Jason Qiu <jason_qiu@hotmail.com>
Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-UIX User Interface, User eXperience, responsiveness c.Bug Bug/defect report good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12276] Instructor edit session page: Fix custom visibility table overflow RohithSurya/teammates
9 participants
@guivilela7 @jasonqiu212 @RohithSurya @Mrityunjaydeepak @nncha96 @domlimm @weiquu @zhaojj2209 @Oshanik22