Create FeedbackResponse and FeedbackResponseComment entities #12135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelfangjw
requested changes
Feb 25, 2023
|
|
||
| @Override | ||
| public int hashCode() { | ||
| // FeedbackResponseComment ID uniquely identifies a Feedback Response Comment. |
There was a problem hiding this comment.
Suggested change
| // FeedbackResponseComment ID uniquely identifies a Feedback Response Comment. |
| import jakarta.persistence.Entity; | ||
|
|
||
| /** | ||
| * Represents a text response. |
There was a problem hiding this comment.
Suggested change
| * Represents a text response. | |
| * Represents a feedback numerical scale response. |
Comment on lines
49
to
51
| @OneToOne | ||
| @JoinColumn(name = "giverSectionId") | ||
| private Section giverSection; |
There was a problem hiding this comment.
This is not a OneToOne relationship. Multiple responses can have the same giverSection.
There was a problem hiding this comment.
right, changed to ManyToOne
Comment on lines
56
to
58
| @OneToOne | ||
| @JoinColumn(name = "receiverSectionId") | ||
| private Section receiverSection; |
Comment on lines
153
to
156
| /* | ||
| * The old FeedbackResponse checks invalidity info for courseId and sessionName, | ||
| * which do not exist on this new entity. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /* | |
| * The old FeedbackResponse checks invalidity info for courseId and sessionName, | |
| * which do not exist on this new entity. | |
| */ |
|
|
||
| @Override | ||
| public int hashCode() { | ||
| // FeedbackQuestion ID uniquely identifies a Feedback Response. |
There was a problem hiding this comment.
Suggested change
| // FeedbackQuestion ID uniquely identifies a Feedback Response. |
| */ | ||
| @Entity | ||
| @Table(name = "FeedbackReponseComments") | ||
| public abstract class FeedbackResponseComment extends BaseEntity { |
There was a problem hiding this comment.
Suggested change
| public abstract class FeedbackResponseComment extends BaseEntity { | |
| public class FeedbackResponseComment extends BaseEntity { |
Comment on lines
43
to
49
| @OneToOne | ||
| @JoinColumn(name = "giverSectionId") | ||
| private Section giverSection; | ||
|
|
||
| @OneToOne | ||
| @JoinColumn(name = "receiverSectionId") | ||
| private Section receiverSection; |
There was a problem hiding this comment.
As above, should not be OneToOne
There was a problem hiding this comment.
changed to ManyToOne
samuelfangjw
approved these changes
Feb 26, 2023
samuelfangjw
pushed a commit
that referenced
this pull request
Feb 26, 2023
samuelfangjw
pushed a commit
that referenced
this pull request
Apr 8, 2023
wkurniawan07
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
FeedbackResponseandFeedbackResponseCommententities.FeedbackResponse,answeris question specific, and thus placed into subtypes, similar to how it's done forFeedbackQuestion.FeedbackParticipantTypeListConverterfromFeedbackQuestionintoBaseEntityas its used byFeedbackResponseComment.FeedbackQuestiontoFeedbackResponse