Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11878] Upgrade instructor request form UI #12929

Merged
merged 32 commits into from
Mar 27, 2024
Merged

[#11878] Upgrade instructor request form UI #12929

merged 32 commits into from
Mar 27, 2024

Commits on Mar 22, 2024

  1. Add confirmation prompt

    @xenosf
    xenosf committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    9ad6ffa View commit details
    Browse the repository at this point in the history

  2. Remove old form iframe

    @xenosf
    xenosf committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    7be6abe View commit details
    Browse the repository at this point in the history

  3. Improve declaration view spacing

    @xenosf
    xenosf committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    f5fc131 View commit details
    Browse the repository at this point in the history

  4. Edit page heading phrasing for clarity

    @xenosf
    xenosf committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    7f8fce6 View commit details
    Browse the repository at this point in the history

  5. Create request form

    @xenosf
    xenosf committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    97bc62a View commit details
    Browse the repository at this point in the history

  6. Add validation messages

    @xenosf
    xenosf committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    3b957d9 View commit details
    Browse the repository at this point in the history

  7. Fix form validation

    @xenosf
    xenosf committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    fc2adad View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Set up form submission confirmation

    @xenosf
    xenosf committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    f3845cc View commit details
    Browse the repository at this point in the history

  2. Create submission acknowledgement view

    @xenosf
    xenosf committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    293275f View commit details
    Browse the repository at this point in the history

  3. Fix URL checking regex

    @xenosf
    xenosf committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    ad7eaf4 View commit details
    Browse the repository at this point in the history

  4. Fix initial state

    @xenosf
    xenosf committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    79bd9ce View commit details
    Browse the repository at this point in the history

  5. Display placeholder when optional field is empty

    @xenosf
    xenosf committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    12a7551 View commit details
    Browse the repository at this point in the history

  6. Fix code style

    @xenosf
    xenosf committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    760a825 View commit details
    Browse the repository at this point in the history

  7. Edit comment for clarity

    @xenosf
    xenosf committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    9f62318 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Fix institution and country combination 

    Co-authored-by: Jay Aljelo Ting <65202977+jayasting98@users.noreply.github.com>
    @xenosf @jayasting98
    xenosf and jayasting98 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    1e4549a View commit details
    Browse the repository at this point in the history

  2. Fix naming

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e5080fb View commit details
    Browse the repository at this point in the history

  3. Remove hard line break

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b213f4d View commit details
    Browse the repository at this point in the history

  4. Add explanatory comment for regex

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2107d3c View commit details
    Browse the repository at this point in the history

  5. Remove newline

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2b155a0 View commit details
    Browse the repository at this point in the history

  6. Add newlines at end of file

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3a11abf View commit details
    Browse the repository at this point in the history

  7. Clear styles file

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0493ddd View commit details
    Browse the repository at this point in the history

  8. Re-add styles file

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    8733e12 View commit details
    Browse the repository at this point in the history

  9. Include test

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e5908b7 View commit details
    Browse the repository at this point in the history

  10. Add test cases for requestSubmissionEvent

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d043af2 View commit details
    Browse the repository at this point in the history

  11. Improve test case readability

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    c1226e9 View commit details
    Browse the repository at this point in the history

  12. Edit test case name for clarity

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    5369ad3 View commit details
    Browse the repository at this point in the history

  13. Add snapshot tests

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ec7395d View commit details
    Browse the repository at this point in the history

  14. Revert "Add snapshot tests" 

    This reverts commit ec7395d.
    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    9744ee5 View commit details
    Browse the repository at this point in the history

  15. Fix lint errors

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    51b0281 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'account-request-form' into arf-instructor-frontend

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3192c87 View commit details
    Browse the repository at this point in the history

  17. Rename methods to be clearer

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    13e9a9e View commit details
    Browse the repository at this point in the history

  18. Disable submit button when not ready to submit

    @xenosf
    xenosf committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a08d997 View commit details
    Browse the repository at this point in the history