Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11878] Merge master into account-request-form #12972

Merged
merged 23 commits into from
Mar 31, 2024

Commits on Mar 23, 2024

  1. Configuration menu
    Copy the full SHA
    9a099c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. [TEAMMATES#12048] Add SQL configuration into build.properties and bui…

    …ld-dev.properties (TEAMMATES#12917)
    
    * Add production config
    
    * Remove forgotten host and password
    
    * Fix lint
    
    ---------
    
    Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
    FergusMok and ziqing26 authored Mar 24, 2024
    Configuration menu
    Copy the full SHA
    e0c6a2d View commit details
    Browse the repository at this point in the history
  2. [TEAMMATES#12048] Add SQL description for postgres config (TEAMMATES#…

    …12931)
    
    * Add production config
    
    * Remove forgotten host and password
    
    * Fix lint
    
    * Address changes, include production_user
    
    * Linting
    FergusMok authored Mar 24, 2024
    Configuration menu
    Copy the full SHA
    845009e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. [TEAMMATES#12588] Improve test code coverage of core components - Toa…

    …stComponent (TEAMMATES#12916)
    
    * add test cases
    
    * add test case for isTemplate()
    
    ---------
    
    Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
    Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
    3 people authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    3499d2a View commit details
    Browse the repository at this point in the history
  2. [TEAMMATES#12588] Add unit tests to question edit answer form (TEAMMA…

    …TES#12935)
    
    * add unit tests to constsum-options-question-edit-answer-form
    
    * add unit tests to constsum-options-question-edit-answer-form
    
    ---------
    
    Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
    cedricongjh and ziqing26 authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    7ba20fc View commit details
    Browse the repository at this point in the history
  3. add delay to task queuer for indexing account request (TEAMMATES#12936)

    Co-authored-by: Nicolas <25302138+NicolasCwy@users.noreply.github.com>
    cedricongjh and NicolasCwy authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    1be2adb View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    716fdc4 View commit details
    Browse the repository at this point in the history
  2. [TEAMMATES#12048] Relax read notif verification for migration verific…

    …ation script (TEAMMATES#12937)
    
    * Fix account requests with wrong field during seed
    
    * Relax account attributes verification
    
    * Fix lint errors
    
    * Fix order of account request variables
    NicolasCwy authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ca20709 View commit details
    Browse the repository at this point in the history
  3. [TEAMMATES#12920] Create script to migrate noSQL test data to SQL sch…

    …ema format (TEAMMATES#12922)
    
    * Add classes to migrate test json data
    
    * Add toposort  script
    
    * Add function to remove foreign key data
    
    * Cleanup
    
    * WIP
    
    * Simplify keys for students and instructors
    
    * Fix lint issues
    
    * Output SQL JSON in same folder as JSON
    
    * Change output file name
    
    * Fix bug: wrong jsonkey used
    
    * Fix lint error
    
    * Make section and team name unique
    
    * Set read notification key to be unique
    
    * Delete python file
    NicolasCwy authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e435f17 View commit details
    Browse the repository at this point in the history
  4. [TEAMMATES#12588] Improve test code coverage of core components - Vie…

    …wResultsPanelComponent (TEAMMATES#12918)
    
    * add test cases to ViewResultsPanelComponent
    
    * fix lint errors
    
    ---------
    
    Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
    Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
    3 people authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a02f444 View commit details
    Browse the repository at this point in the history
  5. fix resetAccountAction (TEAMMATES#12934)

    Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
    cedricongjh and ziqing26 authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    11b8b81 View commit details
    Browse the repository at this point in the history
  6. [TEAMMATES#12048] Migrate Feedback Rank Option E2E test (TEAMMATES#12902

    )
    
    * Initial commit
    
    * Fix lint
    
    * Follow convention and add test
    
    * Change file path
    
    * Fix requested changes
    
    * Fixed testcases
    
    * Fix lint
    
    * Add deepcopy
    
    * Fixed e2e test
    
    ---------
    
    Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com>
    Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
    3 people authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0cfadef View commit details
    Browse the repository at this point in the history
  7. [TEAMMATES#12048] Migrate FeedbackMcqQuestionE2ETest (TEAMMATES#12820)

    * Migrate MCQ E2E
    
    * Fix lint
    
    * Fix lint
    
    * Update xml
    
    ---------
    
    Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
    dishenggg and cedricongjh authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e51132e View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. [TEAMMATES#12048] Remove unnecessary loading of datastore entities in…

    … InstructorNotificationsPageE2ETest (TEAMMATES#12911)
    
    * migrate instructor notif e2e
    
    ---------
    
    Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
    dishenggg and cedricongjh authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    20df6b6 View commit details
    Browse the repository at this point in the history
  2. [TEAMMATES#12048] Migrate InstructorCourseDetailsPageE2ETest (TEAMMAT…

    …ES#12908)
    
    * Add teammates.e2e.cases.sql.InstructorCourseDetailsPageE2ETest
    
    * Remove data properly to prevent clashes
    
    * Add SQL data bundle
    
    * Verify loaded details
    
    * Use email address when getting a student row
    
    * Check student links
    
    * Verify the sending of invites
    
    * Verify the reminding of all students to join
    
    * Remove SQL data properly to prevent clashes
    
    * Verify the downloading of the student list
    
    * Implement helper methods for Student
    
    * Add BaseTestCaseWithSqlDatabaseAccess::verifyAbsentInDatabase
    
    * Add to testng-e2e-sql.xml
    
    * Verify the deleting of students
    
    * Verify the deleting of all the students
    
    * Fix lint
    
    * Remove duplicate equality check for students
    jayasting98 authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a9423da View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. [TEAMMATES#12588] add unit tests for question submission form (TEAMMA…

    …TES#12897)
    
    Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
    cedricongjh and ziqing26 authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    78eee47 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d0cf37 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c4fe140 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. [TEAMMATES#12048] Fix account request indexing (TEAMMATES#12967)

    * Add isTransactionNeeded method to Action
    
    * Remove delay from taskqueuer
    
    * Change CreateAccountRequest to handle own transactions
    cedricongjh authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    356c318 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ee4269 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0855806 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Fix comment style for merge

    ziqing26 committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    18386ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1034ec View commit details
    Browse the repository at this point in the history